I have been doing work on integrating OAuth Connector as a client of a DotNetOpenAuth service provider, which requires POST requests to the token endpoint. However, I noticed that OAuth Connector includes parameters both in GET and POST, is there a reason for that? Shouldn't it be either-or?

Attached is a patch that would fix it.

CommentFileSizeAuthor
#1 oauth.patch517 bytesTripleEmcoder
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TripleEmcoder’s picture

FileSize
517 bytes
TripleEmcoder’s picture

Project: OAuth Connector » OAuth 1.0
Version: 7.x-1.x-dev » 7.x-3.x-dev

Sorry, selected wrong project.

TripleEmcoder’s picture

Project: OAuth 1.0 » OAuth Connector
Version: 7.x-3.x-dev » 7.x-1.x-dev

I am making a fool out of myself... Sorry again.

skylord’s picture

Status: Needs review » Reviewed & tested by the community

+1
Also this behaviour breaks support for russian social network odnoklassniki.ru (second on local market) - it requires POST and is confused when data comes from both ways.
Fixing this doesn't break other providers as i see, so commit is welcome. :-)

bojanz’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.