Work has been done to make Edit production-ready on D7 — see #1879820: [meta] Get the D7 version of Edit production-ready.

A few improvements/bugfixes from there should be ported to Drupal 8:

  1. asnyc load of editors (like ckeditor and attached libraries) upon calling /edit/metadata:
  2. #1893646: display:inline fields are floating around as I hover over them
  3. Modify editable.js to prevent js errors:
  4. #1893700: Links don't work after toggling edit/view mode
  5. Make the quickedit link/tab somewhat easy to reuse from contrib (in case people are not using core toolbar):
  6. Missing drupal.detachBehaviors():
  7. Maybe: #1893698: Hide the In-Place Edit Operations block altogether for unprivileged users
#5 edit_d7_improvements-1894454-5.patch5.23 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 53,112 pass(es). View


nod_’s picture

Issue summary: View changes

More things to port

nod_’s picture

Updated a few things :)

Wim Leers’s picture

Merci beaucoup!

webchick’s picture

Issue tags: +Spark


webchick’s picture

Issue tags: +Edit D7 Backport

Tagging again, to track as part of the larger effort around #1879820: [meta] Get the D7 version of Edit production-ready.

webchick’s picture

Issue summary: View changes


Wim Leers’s picture

Title: [meta] Port improvements from D7 Edit to D8 » Port improvements from D7 Edit to D8
Category: task » bug
Status: Active » Needs review
Issue tags: +sprint
5.23 KB
PASSED: [[SimpleTest]]: [MySQL] 53,112 pass(es). View
  1. Will do, but not here because it's non-trivial. Follow-up issue: #1943776: In-place editors (Create.js PropertyEditor widgets) should be loaded lazily.
  2. Over at #1943696-4: [meta] Bring D7 & D8 Edit in sync; modify broken/revert unnecessary patches, I backported D8 changes to D7. Those changes made this hack obsolete.
  3. This was solved incorrectly in D7. It's already been solved the correct way in D8. The correct way involves not adding more hacks, but instead cleaning up Create.js PropertyEditor widgets to do what they're supposed to do: be dumb and not determine themselves when they're activated. That was the problem here, really: Create.js PropertyEditor widgets decided themselves when they were going to be activated, which makes zero sense.
  4. Problem no longer exists in D8.
  5. No longer relevant, as this is no longer owned by the Edit module.
  6. Done.
  7. Irrelevant for D8; D8 doesn't have such a block.

Problems/clean-ups I encountered while working on D7 Edit, I've also forward ported to D8:

  1. #1891246-6: White background through JS
  2. #1894298: When editing body field with ckeditor teaser == body text

This patch fixes a bunch of smallish bugs:

  • ensures body field modifications don't also modify summaries
  • ensures in-place editing also works well for light-on-dark themes
  • ensures Drupal behaviors are detached for fields edited via in-place forms
  • ensures Drupal 8 will be able to handle display:inline fields like Drupal 7's Edit can (Drupal 8 does not yet have any such fields, because the e.g. the node title is not yet a proper "entity field", it's an "extra field"; this ensures that it will work well)
nod_’s picture

Status: Needs review » Reviewed & tested by the community

All in order.

To be able to test you need to apply: #1942000: Node NG broke Edit module.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

#1942000: Node NG broke Edit module was committed too.

Wim Leers’s picture

Issue tags: -sprint


Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes
    , makes it easier to comment.