This moves the "this is a legacy route" flag to the legacy matcher rather than the legacy controller messing-with listener, so that it's available earlier. This is needed for some of the SCOTCH/Blocks routing logic to make life cleaner.

CommentFileSizeAuthor
earlier-legacy-flag.patch1.64 KBCrell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This looks quite fine, I guess the TODO requires the full conversion?

Status: Needs review » Needs work
Issue tags: -WSCCI, -scotch

The last submitted patch, earlier-legacy-flag.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs work » Needs review
Issue tags: +WSCCI, +scotch

earlier-legacy-flag.patch queued for re-testing.

Crell’s picture

Crell CreditAttribution: Crell commented

Correct, the @todo goes away when the legacy router goes away.

And retesting because I haven't a clue how that fail is even remotely related to this patch...

sdboyer’s picture

sdboyer CreditAttribution: sdboyer commented

woot. yep, this helps us know when to ignore stuff during controller selection.

sdboyer’s picture

sdboyer CreditAttribution: sdboyer commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Yep. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.