adcache.inc uses header() (Devel module incompatibility) [#1893242]

Function adserve_cache_display($ids) uses header() instead of drupal_set_header() which makes it conflict with any modules registering shutdown functions and relying on checking headers like Devel module.

Comment	File	Size	Author
#3	ad-1893242-3.patch	5.29 KB	OnkelTem
#2	ad-1893242-2.patch	64 bytes	OnkelTem
#1	ad-1893242.patch	4.94 KB	OnkelTem

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

OnkelTem CreditAttribution: OnkelTem commented 19 January 2013 at 15:53

Priority:	Major	» Normal
Status:	Active	» Needs review

File	Size
ad-1893242.patch	4.94 KB

Comment #2

OnkelTem CreditAttribution: OnkelTem commented 20 January 2013 at 07:22

File	Size
ad-1893242-2.patch	64 bytes

Using drupal_set_header() raises PHP Fatal error when File cache is ON, since common.inc is not included.
Fixing.

Comment #3

OnkelTem CreditAttribution: OnkelTem commented 20 January 2013 at 07:26

File	Size
ad-1893242-3.patch	5.29 KB

Ops. Wrong export. Retrying.

The new part is:

diff --git a/adserve.inc b/adserve.inc
index c504855..0bf1112 100644
--- a/adserve.inc
+++ b/adserve.inc
@@ -286,6 +286,7 @@ function adserve_include_drupal() {
     }
   }
   require_once adserve_variable('root_dir') .'/includes/bootstrap.inc';
+  require_once adserve_variable('root_dir') .'/includes/common.inc';
 }
 
 /**