In admin/config/development/sync, if there is nothing to import, we might want to hide the "Import all" button. See attached image.

Files: 
CommentFileSizeAuthor
#12 1892662-config-hide-importall-button-12.patch2.4 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 50,383 pass(es). View
#7 1892662-config-hide-importall-button.patch2.4 KBiaha
PASSED: [[SimpleTest]]: [MySQL] 49,725 pass(es). View
#2 1892662-1-dont-show-import-all-button-if-nothing-to-import.patch1.72 KBalberto56
PASSED: [[SimpleTest]]: [MySQL] 49,677 pass(es). View
Screen Shot 2013-01-18 at 2.42.36 PM.png102.35 KBalberto56

Comments

alberto56’s picture

Status: Active » Needs review

Here is a patch for this

alberto56’s picture

FileSize
1.72 KB
PASSED: [[SimpleTest]]: [MySQL] 49,677 pass(es). View

Oops, here it is.

alberto56’s picture

Issue tags: +Configuration system

Status: Needs review » Needs work
Issue tags: -Configuration system

The last submitted patch, 1892662-1-dont-show-import-all-button-if-nothing-to-import.patch, failed testing.

beejeebus’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Configuration system

The last submitted patch, 1892662-1-dont-show-import-all-button-if-nothing-to-import.patch, failed testing.

iaha’s picture

FileSize
2.4 KB
PASSED: [[SimpleTest]]: [MySQL] 49,725 pass(es). View

Patch hides import button when there is nothing to import. Tests updated to assert that import button is/is not hidden as appropriate.

iaha’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -Configuration system

The last submitted patch, 1892662-config-hide-importall-button.patch, failed testing.

rli’s picture

Status: Needs work » Needs review
rli’s picture

swentel’s picture

FileSize
2.4 KB
PASSED: [[SimpleTest]]: [MySQL] 50,383 pass(es). View

Makes sense, did a re-roll because of the trailing spaces in the patch in #7

rli’s picture

Status: Needs review » Reviewed & tested by the community

The patch in #12 works for me.

catch’s picture

Category: feature » bug
Status: Reviewed & tested by the community » Fixed

Makes sense. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.