Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Certain parts of the views integration (node.views.inc is one of them) already checks whether language module exists before integrate the column.
Let's keep that in sync for all of them.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | language_module-1891618-15.patch | 3.06 KB | oriol_e9g |
| #16 | language_module-full-1891618-15.patch | 4.68 KB | oriol_e9g |
| #13 | language_module-1891618-13.patch | 4.72 KB | oriol_e9g |
| #12 | language_module-1891618-12.patch | 3.06 KB | oriol_e9g |
| #2 | drupal-1891618-1.patch | 3.17 KB | dawehner |
Comments
Comment #1
dawehner.
Comment #2
dawehnerWrong patch, sorry.
Comment #3
aspilicious CreditAttribution: aspilicious commentedThank you :)
Comment #5
dawehner#2: drupal-1891618-1.patch queued for re-testing.
Comment #6
aspilicious CreditAttribution: aspilicious commenteddone
Comment #7
catchNot sure about this. If the column always exists, then why not expose it?
Comment #8
dawehnerThe problem is that the actual handler for language lives in the language module, so you would sort of end up with broken values.
Just an idea: put the string handlers in there by default, unless you have the language module available, then you have the full features?
Mh i'm not sure whether it's good, as those handlers could conflict with each other.
Comment #9
dawehner#2: drupal-1891618-1.patch queued for re-testing.
Comment #11
dawehnerAdds tag.
Comment #12
oriol_e9gRerolled and changed the module_exists deprecated calls
Comment #13
oriol_e9gSame patch but with all module_exist calls converted. Feel free to commit/review #13 or #12 and convert rest of the calls in follouwups.
Comment #14
dawehnerThis looks basically perfect.
Ups, right at the end there is some leftover whitespace.
Comment #15
dawehnerComment #16
oriol_e9gComment #17
dawehnerPerfect. I am wondering whether you could complain about the missing test coverage for that, ... I don't know.
Comment #18
catchPre-existing bug but there's no 'langcode' module. Given this is a test module, I'd expect something to fail.
Comment #27
LendudeCleaning up old issues.
This seems to have been fixed by #2143729: Entity definitions miss a language entity key and other things in #2313159: [meta] Make multilingual views work, if you feel this is addressing a different issue, feel free to reopen this.