If a link has a non-empty title and an empty url, then it is supposed to display as plain text. At least, this is how it works in 7.x-1.0. In the dev release from 2012-Aug-17, an empty url gets replaced with the url of the home page.

This change seems to be an unintended consequence of #1645640: Since <front> isn't implemented, take it off the project page until it is., commit b4919a6.

CommentFileSizeAuthor
#2 link-empty-1891340-2.patch1.34 KBbenjifisher
#1 link-empty-1891340-1.patch1.02 KBbenjifisher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher commented
Status: Active » Needs review
FileSize
link-empty-1891340-1.patch1.02 KB

The attached patch fixes the problem for me. It does three things:

  1. Define a new constant, LINK_EMPTY.
  2. Modify link_validate_url($text) to return LINK_EMPTY instead of FALSE if $text is empty.
  3. Check for LINK_EMPTY in _link_sanitize() and conditionally skip the rewriting introduced in #1645640: Since <front> isn't implemented, take it off the project page until it is..
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher commented
FileSize
link-empty-1891340-2.patch1.34 KB

The patch in #1 has indentation errors. Try this one.

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented
Status: Needs review » Closed (duplicate)

This is actually fixed in another recent patch.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher commented

I guess the duplicate issue is #1766150: Title + Optional URL empty not displayed as plain text.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Version: 7.x-1.x-dev » 7.x-1.2
Issue summary: View changes
Status: Closed (duplicate) » Active

This bug has not been fixed in 7.x-1.2.

Neither the patch provided above nor the patch in the "duplicate" issue fix it.

I encountered the bug in 7.x-1.1. After updating to 7.x-1.2 and clearing all caches, the bug persists.

(Note that I am encountering this in conjunction with Link iFrame Fromatter 7.x-1.1.)

CoffeyMachine’s picture

CoffeyMachine CreditAttribution: CoffeyMachine commented
Status: Active » Fixed

This is working for me in 7.x-1.3.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.