Some images with exif data not reading co ordinates

I was having the exact same problem for a while. Thank u so much! This worked great!

Some images were working, others were not. it seemed so random. Now it all works!

Thanks man, you saved my day!

Here is a patch with iancawthorne's solution.

file_create_url() does create a web accessible URL and the documentation for exif_read_data() states that This cannot be an URL., so I find that strange... But the patch applies cleanly on -dev version.

thank you for the patch :)

I guess it counts as enough reviews.

Hi,
Geocoder exif plugins seems to read GPS data only when it is written in a certain format.
While geocoder works fine with :
Equipment Make: SAMSUNG
Camera Model: GT-I9000
Camera Software: fw 15.16 prm 08.06
(...)
Latitude: N 44� 48' 9
Longitude: E 1� 37' 10
Altitude: 313.99 m

I recently had a trouble with a photo where coordinates were recorded as :

Equipment Make: SAMSUNG
Camera Model: GT-N7000
Camera Software: N7000XXLT5
(...)
Latitude: N 44.8662001� 0'
Longitude: E 2.3135504� 0'
Altitude: 81.28 m

A special mention for GPS Camera Free application that stores coordinates in the file name and nowhere else, like
44722832_2238793_1383840808262.jpg

I discovered this with exiftags, as exiv2 doesn't display GPS infos ans exiftool displays them all in the same format.

I'm quite new to Drupal, trying to build a site, but I once was a php developper. if I can help, tell me.

@eluthere, did you test with or without the patch? Do you confirm the patch is working?

I use Drupal 7.31 / Commons (commons-7.x-3.17)
I rebuilt my site entirely this summer. I suppose the 2 years old patch is included.

I just tested with a few photos.
- Two native photo taken with a GT I9000 passed the test (2013-01-20 10.56.07.jpg, 1,6Mb and 2014-03-23 15.17.48.jpg), even if 2013-01-20 10.56.07.jpg had no recorded coordinate.
- A photo taken with a GT-N7000 and reduced in size with Gimp passed the test. (20140731_115356-s.jpg)
Its original is 2,5Mb, over the 2Mb limit.
- A 1Mb photo taken with a GT-N7000 caused an error:
" Warning: exif_read_data(20140831_153454.jpg): Error reading from file: got=x3FFA(=16378) != itemlen-2=x90DA(=37082) in geocoder_exif() (line 25 of /home/patrick/art4/sites/all/modules/geocoder/plugins/geocoder_handler/exif.inc).
Warning: exif_read_data(20140831_153454.jpg): Invalid JPEG file in geocoder_exif() (line 25 of /home/patrick/art4/sites/all/modules/geocoder/plugins/geocoder_handler/exif.inc)."
It did not provide its coordinates wheraes exiftags says :
"Latitude: N 48.8232863� 0'
Longitude: E 2.3548576� 0'
Altitude: 110.91 m"

When I tried to remove it as the forum icon, I had another error:
"Exception: Invalid GeoJSON: GeometryCollection with no component geometries in GeoJSON->objToGeometryCollection() (line 104 of /home/patrick/art4/sites/all/modules/geophp/geoPHP/lib/adapters/GeoJSON.class.php).
The website encountered an unexpected error. Please try again later. "

- A 125ko photo taken with a GT-N7000 passed the test (20140928_160239.jpg)

I noted their names in order to be able to send them to you if necessary.
Telle me what you think

@eleuthere, the patch has not been committed yet. Could you eventually test with it? It it's ok for you too, I think I'll commit it.

I applied the patch on the /sites/all/modules/geocoder directory
Then I made dopies of my previous photos.
I could create groups. They were correctly located without error messages.
I did not check if I could remove or change the images, nor anything else.
Thanks.
I stay available for more if necessary.

I went with it. Thanks everybody for the patch and the feedback!

Thanks. This patch worked perfectly for me with photos geo-referenced using JetPhoto Studio.

Please Update this patch according to php specification:
http://php.net/manual/en/function.exif-read-data.php

Parameters
filename :The name of the image file being read. This cannot be an URL.

So line 25 becomes:
if ($data = exif_read_data(drupal_realpath($url))) {

Patch #3 does not work with private files.

Please use the patch from #16. This one is also more efficient.

Thanks for the patch.

Can I have one more review before committing it, to be sure not to make any regression this time?

#16 works fine, but I renamed the $url argument to $uri, which represents it better...

Committed, thanks!