Right now it is protected and you need to completely override by PluginManagerBase::createInstance() and extend DefaultFactory::createInstance() to use it while expanding your plugin's constructor.

CommentFileSizeAuthor
#1 plugin-1889826-1.patch4 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +Blocks-Layouts, +Plugin system, +Block plugins
FileSize
plugin-1889826-1.patch4 KB

This blocks #1871696: Convert block instances to configuration entities to resolve architectural issues

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

The other option would be to make it a non-static public method on DiscoveryInterface. That has the benefit of not being static, but I think it makes more sense on the factory.

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented

I think this is fine.

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented
Status: Needs review » Reviewed & tested by the community

Since this is blocking #1871696: Convert block instances to configuration entities to resolve architectural issues.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Priority: Normal » Critical

This blocks a critical.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. I don't mind it being static; static method calls are usually faster than virtual method calls.

Automatically closed -- issue fixed for 2 weeks with no activity.