JsonldBundle has confused me in #1850704: Available serialization formats: we only have one encoder so the foreach loop makes it unnecessarily complex.

CommentFileSizeAuthor
#2 jsonld-encoders-1889244-2.patch1.45 KBklausi
#1 jsonld-encoders-1889244-1.patch1.45 KBklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
FileSize
jsonld-encoders-1889244-1.patch1.45 KB

Simple patch attached.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
FileSize
jsonld-encoders-1889244-2.patch1.45 KB

Fixed comment style that linclark pointed out.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Title: Remove encoder array as there is only one encoder » Remove JSON-LD encoder array as there is only one JDON-LD encoder

This looks good to me. There were originally two encoders, so that's probably how this ended up being an array.

Once it's green, it's fine for RTBC.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Title: Remove JSON-LD encoder array as there is only one JDON-LD encoder » Remove JSON-LD encoder array as there is only one JSON-LD encoder
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Reviewed & tested by the community

RTBC per #4.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Looks much nicer. Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.