Right now, ConfigEntityListController::load() calls ConfigEntityBase::sort(), but it's always ConfigEntityBase, not necessarily the subclass that's being listed.

Files: 
CommentFileSizeAuthor
#5 configentity-1888688-5.patch2.16 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 49,057 pass(es). View
#2 configentity-1888688-2-FAIL.patch1.53 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 49,398 pass(es), 1 fail(s), and 0 exception(s). View
#2 configentity-1888688-2-PASS.patch2.16 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 49,397 pass(es). View
#1 configentity-1888688-1.patch644 bytestim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 50,820 pass(es). View

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
644 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,820 pass(es). View

Here's the fix, needs tests.

tim.plunkett’s picture

Issue tags: -Needs tests
FileSize
2.16 KB
PASSED: [[SimpleTest]]: [MySQL] 49,397 pass(es). View
1.53 KB
FAILED: [[SimpleTest]]: [MySQL] 49,398 pass(es), 1 fail(s), and 0 exception(s). View

Here's a test.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

If this passes/fails as expected then this looks good to me. Test and fix is correct.

I think this is the proper behavior, otherwise sort() would have to be defined in a way that makes it obvious that it can't be overriden (static final) which would provide no benefits.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, this does not seem to apply for me. :(

tim.plunkett’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
2.16 KB
PASSED: [[SimpleTest]]: [MySQL] 49,057 pass(es). View

Ah, yes my own patch broke it :)
#1889854: Config import breaks on protected entity properties

Both added a method to the end of a file, I just put this one below the other, so setting back to RTBC.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.