Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Right now, ConfigEntityListController::load() calls ConfigEntityBase::sort(), but it's always ConfigEntityBase, not necessarily the subclass that's being listed.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | configentity-1888688-5.patch | 2.16 KB | tim.plunkett |
| #2 | configentity-1888688-2-FAIL.patch | 1.53 KB | tim.plunkett |
| #2 | configentity-1888688-2-PASS.patch | 2.16 KB | tim.plunkett |
| #1 | configentity-1888688-1.patch | 644 bytes | tim.plunkett |
Comments
Comment #1
tim.plunkettHere's the fix, needs tests.
Comment #2
tim.plunkettHere's a test.
Comment #3
BerdirIf this passes/fails as expected then this looks good to me. Test and fix is correct.
I think this is the proper behavior, otherwise sort() would have to be defined in a way that makes it obvious that it can't be overriden (static final) which would provide no benefits.
Comment #4
webchickSorry, this does not seem to apply for me. :(
Comment #5
tim.plunkettAh, yes my own patch broke it :)
#1889854: Config import breaks on protected entity properties
Both added a method to the end of a file, I just put this one below the other, so setting back to RTBC.
Comment #6
catchCommitted/pushed to 8.x, thanks!