Since #1608842: Replace list of bootstrap modules, enabled modules, enabled themes, and default theme with config, update_retrieve_dependencies() no longer considers disabled modules.

No test coverage for it either

Patch and test to follow.

Files: 
CommentFileSizeAuthor
#5 update-retrieve-dependencies-1887904.5.fail_.patch2.32 KBlarowlan
FAILED: [[SimpleTest]]: [MySQL] 49,615 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#5 update-retrieve-dependencies-1887904.5.pass_.patch4.06 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 49,695 pass(es).
[ View ]
#1 update-retrieve-dependencies-1887904.fail_.patch2.5 KBlarowlan
PASSED: [[SimpleTest]]: [MySQL] 49,591 pass(es).
[ View ]
#1 update-retrieve-dependencies-1887904.pass_.patch3.39 KBlarowlan
FAILED: [[SimpleTest]]: [MySQL] 49,701 pass(es), 0 fail(s), and 3 exception(s).
[ View ]

Comments

larowlan’s picture

Status:Active» Needs review
StatusFileSize
new3.39 KB
FAILED: [[SimpleTest]]: [MySQL] 49,701 pass(es), 0 fail(s), and 3 exception(s).
[ View ]
new2.5 KB
PASSED: [[SimpleTest]]: [MySQL] 49,591 pass(es).
[ View ]

Note that .pass patch won't pass as there are un-resolved dependencies in HEAD.
Actual .pass patch will need to fix those too.

larowlan’s picture

Title:update_retrieve_dependencies() only considers enabled modules, disabled modules not» update_retrieve_dependencies() only considers enabled modules

Status:Needs review» Needs work

The last submitted patch, update-retrieve-dependencies-1887904.pass_.patch, failed testing.

larowlan’s picture

Assigned:Unassigned» larowlan

something not right, will re-visit test when I have a clean head
as mentioned the fail is expected in the .pass test, just not the pass in the .fail test (if that makes sense)

larowlan’s picture

Status:Needs work» Needs review
StatusFileSize
new4.06 KB
PASSED: [[SimpleTest]]: [MySQL] 49,695 pass(es).
[ View ]
new2.32 KB
FAILED: [[SimpleTest]]: [MySQL] 49,615 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Yeah test is dud, update_test_1_8002 runs before user_update_8016 even though update_test_1_update_dependencies() is *NOT* invoked.
New test just sets a state variable when update_test_1_update_dependencies() runs and checks for that in the test.
Here is new .fail and .pass patches.

catch’s picture

Status:Needs review» Reviewed & tested by the community
larowlan’s picture

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.