currently, we allow modules that define config entities to signal that they are not going to handle a change during import by returning false from StorageController::importChange/Delete/New implementations.
this is probably not safe, as we enforce different rules for plain old config objects (POCOs) vs plain old config entity objects (POCEOs).
with POCOs, key changes within a config file are fine, with POCEOs, they are not.
so this patch unconditionally removes any files from the list of import changes that are passed to config_import_invoke_owner().
Comment | File | Size | Author |
---|---|---|---|
#3 | config-1887304-3.patch | 1.52 KB | tim.plunkett |
#1 | 1887304-poco-vs-pocoe.patch | 622 bytes | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedand here's the simple patch.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedchanging component. not sure.
Comment #3
tim.plunkettIf we do, we should clean up the methods as well.
However, not sure how to combine this with #1886478: Bring back hook_config_import_CRUD() hooks
Comment #4
sunHm. I've to admit that I did not understand the problem space that is described in the OP. Can we clarify that?
In any case, we probably want to return the result of ::save() here.
Comment #5
tim.plunkettWe can return whatever we want, we don't check it anywhere.
Comment #6
jibran#3: config-1887304-3.patch queued for re-testing.
Comment #8
mtiftComment #9
tim.plunkettPretty sure this is irrelevant now. #2218003: ConfigImporter assumes that a ConfigEntity uses a storage controller that implements ConfigStorageControllerInterface removed the return checking of import*