This module enables you to render a FlexSlider using referenced entities as your slides.
It provides a field formatter for entityreference fields, with the following settings;

  • FlexSlider option set
  • View mode for slides
  • View mode for thumbnails

Sandbox URL: https://drupal.org/sandbox/bendik/1886168

Git: git clone http://git.drupal.org/sandbox/bendik/1886168.git flexslider_entityreference

Files: 
CommentFileSizeAuthor
#14 2013-03-01-02:52:31.jpg6.74 KBdrupik

Comments

klausi’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1606634
Project 2: http://drupal.org/node/1886184

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

bendikrb’s picture

Status: Closed (duplicate) » Needs review
klausi’s picture

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

alexmoreno’s picture

Status: Needs review » Needs work

Thanks for contributing your module.

I've tryed to clone the project to read the code and do some automated tests but it seems the project is empty.

Also, the main git branch should be pointing to a current drupal version, like drupal 7 or drupal 6. Currently it points to master.

Also, please, provide more information about your project and how to download it.

Runing paraview.sh also throws this (as klausi points):

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

And this validation issues in Drupal coding standards.

37 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
83 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
92 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
100 | ERROR | else must start on a new line
161 | ERROR | Files must end in a single new line character

Thank you.

bendikrb’s picture

Status: Needs work » Needs review

Thanks for your review.
I am not working in the master branch. All my code is in 7.x-1.x. I have made this the default branch now.

The issues reported by paraview is now corrected.

alexmoreno’s picture

From my point of view the module can be ready to publish. I you could follow the advice of bendikrb, if you help with at least 3 or 4 reviews of other modules waiting, you'll help others to leave their sandboxes (like myself, I will have a module in a few days ready) and your module will be approved sooner.

A few tips that could be useful:

http://www.programadoresweb.net/drupal-sprint-london-january-2013/26-01-...

Thank you.

fago’s picture

Status: Needs review » Needs work

I could use the module, so I reviewed it:

name = FlexSlider Entityreference
description = Adds a FlexSlider field formatter for Entity reference fields

Inconsistent spelling for "Entityreference", this should follow the spelling of the entity reference project.

 * @file
 * Provides a FlexSlider formatter for entityreference fields.
 * Uses a lot of code from both entityreference and flexslider_fields.
 *
 * @author Bendik R. Brenne <bendik@konstant.no>

Credits should take place in README.txt not in @file blocks.

    $o = flexslider_optionset_load($settings['optionset']);
    if ($o !== NULL) {

Use verbose variables names, $o says nothing. Also, instead of !== NULL use isset($var) unless not possible.

        // Protect ourselves from recursive rendering.
        static $depth = 0;
        $depth++;
        if ($depth > 20) {
          throw new EntityReferenceRecursiveRenderingException(t('Recursive rendering detected when rendering entity @entity_type(@entity_id). Aborting rendering.', array('@entity_type' => $entity_type, '@entity_id' => $item['target_id'])));
        }
        $entity = clone $item['entity'];
        unset($entity->content);

It's good to have that kind of protection.

This could use a comment why it's necessary to clone, e.g. to support rendering the same entity in another view-mode on itself?

Except of that the code looks pretty solid and should be ready. Good work!

bendikrb’s picture

Status: Needs work » Needs review

Thanks again for your review!

I have corrected the issues you have pointed out, and added a README file.

alexmoreno’s picture

remember to help wit 3 or 4 reviews like this one :-)

bendikrb’s picture

Will do!
It's not than i'm being ignorant, I'm just burried with work nowadays.
I'll do some reviewing as soon as I find the time for it :)

alexmoreno’s picture

Sorry bendikrb, I didn't want to mean nothing about you or being disrespectful. It is just that It's the typical thing that a lot of projects lack of. Once you know how to do it, it is very easy and you will help others like you (or myself) to leave the sandbox.

Thank you, have a lovely weekend.

stevector’s picture

The project page should link to the Flexslider module page http://drupal.org/project/flexslider and contain some mention of compatibility with versions 1 and 2 of flexslider module.

bendikrb’s picture

Project page is now updated

drupik’s picture

FileSize
6.74 KB

Hi bendikrb.
flexslider_entityreference.module - line 6: - It seems that you still not removed the tag @author from @file block mentioned by @fago.

Add git clone command to your issue summary: git clone http://git.drupal.org/sandbox/bendik/1886168.git flexslider_entityreference

flexslider_entityreference.info - you have this: package = FlexSlider, flexslider module have: package = Flex Slider, on the modules page they are two separate groups.

The rest looks great.

Good Luck :)

bendikrb’s picture

Thanks drupik.
I have now done the changes you have pointed out.

drupik’s picture

Cool.
git clone - I mean here, in issue summary (the first post) not on the project page, there currently is ;) http://drupal.org/node/1011698 - point 6

bendikrb’s picture

Right, ok. Done! :)

drupik’s picture

Hi bendikrb.

Can you explain what I'm doing wrong? :)

  • Fresh install Drupal 7.20 - 5.3.10-1ubuntu3.5
  • Modules installed: entity_reference, flexslider, flexslider_fields, flexslider_entityreference, libraries, ctools.
  • Created 3 articles, added entity_reference field with max 3 options.
  • In one article I choose the other two as entity reference.
  • In 'manage display': Format: flexslider, Option set: Default settings, Slides rendered as: Teaser,
    Thumbnails rendered as: empty string
  • Does not display anything, I get an empty div

Rendered entity works well, as well as a image with flexslider.

bendikrb’s picture

Hi drupik,
do you have Flexslider working before trying my module?

You need the contrib library for it (jquery.flexslider.js), please see the instructions on the flexslider project page.
Also make sure you are using version 2 of the flexslider module.

drupik’s picture

Status: Needs review » Reviewed & tested by the community

Yes, it worked before, but I had a different version.
Yeah, now it works with entityreference! I has flexslider 7.x-1.0-rc3 because it is recommended release. You should add info about this to install flexslider 2.0, because it definitely does not work with 7.x-1.0 version. Also, you can add more specified dependencies to the .info file, see: http://drupal.org/node/542202#dependencies.
You can change back in the .info file package = Flex Slider, because since version 2 it is: package = FlexSlider (my bad).
It looks great, works even on responsive theme. I will definitely use this module in the future.
Changing the status to RTBC, but the rest is in the hands of git admin. To speed up the process, you can do 3 reviews (as I do now :) http://drupal.org/node/1410826
That's all from my side, keep the good work.
Greetings.

bendikrb’s picture

Thanks for your review drupik!

I have now made the flexslider dependency version specific and changed back the package string.

mitchell’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, bendikrb!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks to the dedicated reviewer as well.

bendikrb’s picture

Thanks alot guys!

I have promoted the project and added a release candidate;
https://drupal.org/project/flexslider_entityreference

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Added git clone