NodeRevisionsTest.php contains two classes, not PSR-0 [#1885868]

Comment	File	Size	Author
#8	node-revision-missing-test-1885868-8.patch	10.74 KB	Berdir

#8	node-revision-missing-test-1885868-8-interdiff.txt	844 bytes	Berdir
#6	1885868-6.patch	10.74 KB	swentel

#6	interdiff.txt	1.24 KB	swentel
#1	node-tests-not-psr0-1885868.1.patch	10.74 KB	larowlan

Comment #1

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 11 January 2013 at 06:23

Component:	documentation	» node.module
Status:	Active	» Needs review

File	Size
node-tests-not-psr0-1885868.1.patch	10.74 KB

Log in or register to post comments

Comment #2

11 January 2013 at 07:12

Status:

Needs review

» Needs work

The last submitted patch, node-tests-not-psr0-1885868.1.patch, failed testing.

Log in or register to post comments

Comment #3

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 11 January 2013 at 09:26

Priority:

Normal

» Major

Bumping priority seeing as though this is broken in HEAD

Log in or register to post comments

Comment #4

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 11 January 2013 at 09:37

Commit at fault here was 3c7447f8 which was #880940: view/revert/delete revisions per content type

Log in or register to post comments

Comment #5

realityloop

he/him

CreditAttribution: realityloop commented 15 January 2013 at 05:54

Time permitting, we've just had our first baby arrive, I'll try and get this working on the weekend.

Log in or register to post comments

Comment #6

swentel CreditAttribution: swentel commented 21 January 2013 at 15:09

Status:

Needs work

» Needs review

File	Size
interdiff.txt	1.24 KB
1885868-6.patch	10.74 KB

so isCurrentRevision() got renamed apparently to isDefaultRevision() - but this triggers errors in the test, didn't have time to look into it though

Log in or register to post comments

Comment #7

21 January 2013 at 17:19

Status:

Needs review

» Needs work

The last submitted patch, 1885868-6.patch, failed testing.

Log in or register to post comments

Comment #8

Berdir

German

Switzerland

CreditAttribution: Berdir commented 26 January 2013 at 00:22

Status:

Needs work

» Needs review

File	Size
node-revision-missing-test-1885868-8-interdiff.txt	844 bytes
node-revision-missing-test-1885868-8.patch	10.74 KB

node_load($node->nid, $nod->vid) is now node_revision_load($node->vid), the second argument is the cache reset which means that it would load the default revision.