When changing PhpStorage to use the non-secure, plain FileStorage via settings.php, in order to be able to debug/edit dumped PHP files, like this:

$conf['php_storage']['default']['class'] = 'Drupal\Component\PhpStorage\FileStorage';

(Background: You cannot touch/debug/edit dumped PHP files with the MTime*Storages.)

...then you get this PHP warning in many places, whenever ::save() is invoked:

mkdir(): File exists
	Warning	FileStorage.php	56	Drupal\Component\PhpStorage\FileStorage->save()
CommentFileSizeAuthor
#1 drupal8.php-file-save.1.patch602 bytessun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

Status: Active » Needs review
FileSize
602 bytes

This patch fixes it.

sun’s picture

Status: Needs review » Reviewed & tested by the community

mmm... looks like no one is using the bare PhpStorage\FileStorage.

This issue actually has nothing to do with Windows... Just simply not using the default PhpStorage\MTimeProtectedFileStorage implementation (jesus, what a name...).

I'm getting a complete dump of the Kernel container + PHP warning (as exception in tests), each time the kernel is rebuilt, which leads to plenty of false-positive test failures. :(

So please excuse me for going out of line of procedures here, but these error messages are really getting annoying :-/

moshe weitzman’s picture

Issue tags: -Windows

Looks fine. RTBC is legit.

sun’s picture

"Thanks" to this bug, I was at least able to discover #1897468: Kernel rebuilds service container on every request when a module vanishes ;)

So yeah, once in a while, bugs are indeed features :P

catch’s picture

Status: Reviewed & tested by the community » Fixed

Looks fine. Committed/pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.