in core/lib/Drupal/Core/Ajax/AjaxResponse.php and core/includes/ajax.inc there is a duplicate code comment, which is both unclear and references md5(), which we wouldn't use now per Drupal secure coding standards at http://drupal.org/node/845876

Files: 
CommentFileSizeAuthor
#5 1884840-5.patch821 bytesPix_
PASSED: [[SimpleTest]]: [MySQL] 40,054 pass(es).
[ View ]
#1 1884840-1.patch1.75 KBpwolanin
PASSED: [[SimpleTest]]: [MySQL] 49,789 pass(es).
[ View ]

Comments

pwolanin’s picture

Status:Active» Needs review
StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 49,789 pass(es).
[ View ]
jhodgdon’s picture

Assigned:Unassigned» jhodgdon
Status:Needs review» Reviewed & tested by the community

OK, I'll get tihs committed. Thanks! Does it need backporting to 7?

jhodgdon’s picture

Version:8.x-dev» 7.x-dev
Assigned:jhodgdon» Unassigned
Status:Reviewed & tested by the community» Patch (to be ported)

Committed to 8.x. I think it can probably be ported to 7.x by grepping for md5 to find the relevant comments.

pwolanin’s picture

Yes, looks like these are comments that were added in D7

Pix_’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new821 bytes
PASSED: [[SimpleTest]]: [MySQL] 40,054 pass(es).
[ View ]

Backport for d7 attached

pwolanin’s picture

Status:Needs review» Reviewed & tested by the community

looks good

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks - committed to 7.x.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.