This module interferes with Drupal 7 core's "Cancel own user account" permission.

When administerusersbyrole is enabled I get an access denied if I try to cancel my own account.

Files: 
CommentFileSizeAuthor
#4 administerusersbyrole-cancel-own-account-1883856-4.patch821 byteskorgik
PASSED: [[SimpleTest]]: [MySQL] 1,141 pass(es).
[ View ]

Comments

smussbach’s picture

Priority:Normal» Major

This is a quite big one. No reactions? Pushing this to major as users should know this when planning to use this module.

korgik’s picture

Issue summary:View changes
Status:Active» Needs review
StatusFileSize
new881 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch administerusersbyrole-cancel-own-1883856-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

My patch should fix this bug.

Status:Needs review» Needs work

The last submitted patch, 2: administerusersbyrole-cancel-own-1883856-2.patch, failed testing.

korgik’s picture

StatusFileSize
new821 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,141 pass(es).
[ View ]

Try to pass test

korgik’s picture

Status:Needs work» Needs review
korgik’s picture

any updates here?

korgik’s picture

Still no updates here?

Jason Dean’s picture

#4 works great - thanks!

AdamPS’s picture

Assigned:Unassigned» AdamPS
Issue tags:+beta2

I intend to fix this as part of #2378869: Meta-issue for Beta 2 release. Please sign up as a follower of that issue and see the patch there that I would like feedback on.

It's effectively a similar patch but I couldn't take your patch directly because there are so many issues to fix affecting the same lines of code.

korgik’s picture

Nice to see what module will be maintained, but if you will use the code from my patch it would be pretty nice to see me as commit author somehow.

AdamPS’s picture

@korgik Sorry as I explained in the main Beta2 issue there will only be one commit for all the outstanding bugs (about 20 of them, all overlapping!) - it's the only way I can deal with the huge backlog in a practical amount of time. I'm afraid you will have to be satisfied with a warm glow inside for having done your bit to help:-).

It's not quite the same code as yours - basically I made a call to user_cancel_access (just 3 lines) which seems like the best solution as saves duplicating the code and is more future-proof.

What I really need now is people to test the new patch - I hope you can help out.

AdamPS’s picture

Version:7.x-1.x-dev» 7.x-2.0-beta1
Status:Needs review» Closed (fixed)

Fix now available in latest release