Please add instagram and pinterest to the list of Follow services.

CommentFileSizeAuthor
#13 support_for_instagram-1879484-13.patch15.13 KBmkhamash
#6 follow-instagram_pinterest-1879484_1895014.patch1.46 KBcwithout
#6 icons.zip10.19 KBcwithout
#3 follow-add_instagram_support-1879484-3.patch1.21 KBfloydm
#3 icon-instagram.png3.91 KBfloydm
#3 icon-instagram.png2.25 KBfloydm
#1 follow_instagram.zip8.11 KBFernando Vesga
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Fernando Vesga’s picture

Fernando Vesga CreditAttribution: Fernando Vesga commented
FileSize
follow_instagram.zip8.11 KB

Try this.

Is the pinterest version from http://drupal.org/node/1667782, and addapted for instagram.

It works for me

bmx269’s picture

bmx269 CreditAttribution: bmx269 commented

Thanks

floydm’s picture

floydm CreditAttribution: floydm commented
Status: Active » Needs review
FileSize
icon-instagram.png (small)2.25 KB
icon-instagram.png (large)3.91 KB
follow-add_instagram_support-1879484-3.patch1.21 KB

Patch adds instagram support to the 7.x-1.x branch.

rwinikates’s picture

rwinikates CreditAttribution: rwinikates commented

Any chance of getting this committed?

q0rban’s picture

q0rban CreditAttribution: q0rban commented

Yes, there is a very good chance this will get committed. Follow really needs some more co-maintainers for stuff like this.

cwithout’s picture

cwithout CreditAttribution: cwithout commented
FileSize
icons.zip10.19 KB
follow-instagram_pinterest-1879484_1895014.patch1.46 KB

Patch for 7.x-2.x using the icons provided in #3. Also adds Pinterest just to make things easier since they're similar.

Steps:

  • Apply patch.
  • Unzip icons.zip
  • Copy unzipped icons directory to follow directory to add pinterest and instagram icons
  • Edit and save your block to recreate the CSS (admin/structure/block/manage/follow/site/configure)

q0rban, if you'd like to add me as a comaintainer, I can add the patches for instagram and pinterest. I find myself having to apply these patches on almost every site I use follow on. So it would be less time for me to just work on getting these committed.

BWPanda’s picture

BWPanda CreditAttribution: BWPanda commented
Issue summary: View changes
Status: Needs review » Needs work

Pinterest support has been requested separately in #1667782: Pinterest support, so this patch should be edited to just add support for Instagram.

vibrasphere’s picture

vibrasphere CreditAttribution: vibrasphere commented
Status: Needs work » Needs review

Patch #6 works great on latest 7.x-2.x including the icons.zip, adds both Pinterest and Instagram, should be committed. Don't see any reason to make it add Instagram only when you can have both.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste commented
Title: instagram » Support for instagram and pinterest
Issue summary: View changes
sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste commented
Status: Needs review » Reviewed & tested by the community

Works fine.

joshmbuck’s picture

joshmbuck CreditAttribution: joshmbuck commented

can someone please tell me why I can't the get icons to show up? I get the links, and they work fine, but I can't get the pinterest icon to appear.

never mind...small typo and all is well now :)

adelka’s picture

adelka CreditAttribution: adelka commented

#6 works.
GREAT WORK, thank you!

mkhamash’s picture

mkhamash CreditAttribution: mkhamash as a volunteer commented
FileSize
support_for_instagram-1879484-13.patch15.13 KB

I have re-rolled patch #6 and included the images from icons.zip into the patch file, for anyone how needs to use the patch inside a make file, though it is still missing icons in wpzoom** icons directories for instagram & pinterest.

Hope this issue get sorted out there are multiple issues to add services with a lot of duplicate issues.

Also can be applied through cli using git apply:

cd follow;
wget http://www.drupal.org/files/issues/support_for_instagram-1879484-13.patch;
git --git-dir=. apply -p1 ./support_for_instagram-1879484-13.patch --verbose
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
CreditAttribution: scuba_fly at LimoenGroen commented

Can somebody commit this ? I'm open for a co-maintainership if needed.
#6 is working, and the added #13 works as well

Thanks!

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Kalamuna commented

I'd love to see this committed as well. Would also be interested in co-maintaining if we still need people to help.

Skanzo’s picture

Skanzo CreditAttribution: Skanzo commented

It seems like there are a lot of new and better sites that need to be implemented here. I see other requests for BandCamp and more.
What really seems like the best solution, is to be able to create CUSTOM links and upload the icon yourself.

  • RobLoach committed 80f4db3 on 7.x-2.x authored by mkhamash 
    Issue #1879484 by floydm, cwithout, mkhamash, Fernando Vesga: Support...
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach at Kalamuna commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Assigned: Unassigned » RobLoach
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.