Use 'delete' over 'remove' in the aggregator module

Updated the remove text

#1: aggregator-renameremove-707484.patch queued for re-testing.

#1: aggregator-renameremove-707484.patch queued for re-testing.

makes sense

I think we should go the whole way and rename the routines removeFeedItems(), updateAndRemove(),aggregator_remove(), ProcessorInterface::remove()

Also the route /admin/config/services/aggregator/remove/{aggregator_feed}

Also the confirm form question Are you sure you want to remove all items from the feed %feed?

The message The news items from %site have been removed.

Also update comments

   * Called by aggregator if either a feed is deleted or a user clicks on
   * "remove items".

   * Tests running "remove items" from 'admin/config/services/aggregator' page.

      // Remove all items that are older than flush item timer.

RemoveFeedItemTest which itself should be renamed...

Basically just search for remove in the aggregator code base... because just limiting the scope to "remove items" => "delete items" actually makes aggregator inconsistent.

The patch no longer applies; it needs to be re-rolled.

Thanks InternetDevels. I have checked the patch its working fine for me.

This patch no longer applies. Needs reroll.

Reroll.

Corrections to newly added tests.

1. +++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/aggregator/processor/DefaultProcessor.php
   @@ -193,17 +193,17 @@ public function process(FeedInterface $feed) {
   -   * Implements \Drupal\aggregator\Plugin\ProcessorInterface::postProcess().
   +   * Itmplements \Drupal\aggregator\Plugin\ProcessorInterface::postProcess().
   

   oops, typo:P

   But since we are there change it to inheritdoc

2. +++ b/core/modules/aggregator/lib/Drupal/aggregator/Tests/FeedParserTest.php
   @@ -23,7 +23,7 @@ public static function getInfo() {
   -    // Do not remove old aggregator items during these tests, since our sample
   +    // Do not deleted old aggregator items during these tests, since our sample
   

   should be "Do not delete "

Also would be nice to git diff with the -M option. Makes the patch easier to read when there are renamed/moved files

Thanks for the diff -M tip

I will add it as an optional parameter to step 13 of https://drupal.org/patch/reroll

Thank you:)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/ProcessorInterface.php
@@ -46,14 +46,14 @@ public function process(FeedInterface $feed);
-  public function remove(FeedInterface $feed);
+  public function delete(FeedInterface $feed);

we need to update existing change notices about this change here (which i guess should happen after commit?)

What about Drupal\aggregator\Tests\RemoveFeedTest?

Renamed file, fixed class name, getInfo() references etc.

Committed 81d8c4a and pushed to 8.x. Thanks!

We need to ensure that the change notices for aggregator are up to date.

Thanks all
change notices updated
https://drupal.org/node/1957310
https://drupal.org/node/2191221