Problem/Motivation

The controller resolver service in Symfony is named "controller_resolver" instead of resolver. For better interoperability, using the same name in Drupal would help a lot. Also, as we can imagine having more than one resolvers, having a more descriptive is nice added bonus.

Proposed resolution

The patch renames the service from "resolver" to "controller_resolver".

CommentFileSizeAuthor
#6 resolver-rename.patch1.23 KBfabpot
controller_resolver.patch1.08 KBfabpot
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense to me.

webchick’s picture

Category: feature » task

Re-assigning as a task. This doesn't seem to apply for me though.

webchick’s picture

controller_resolver.patch queued for re-testing.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

This no longer applies for me. Here's the .rej file:

***************
*** 103,114 ****

      $container->register('dispatcher', 'Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher')
        ->addArgument(new Reference('service_container'));
-     $container->register('resolver', 'Drupal\Core\ControllerResolver')
        ->addArgument(new Reference('service_container'));
      $container->register('http_kernel', 'Drupal\Core\HttpKernel')
        ->addArgument(new Reference('dispatcher'))
        ->addArgument(new Reference('service_container'))
-       ->addArgument(new Reference('resolver'));
      $container->register('language_manager', 'Drupal\Core\Language\LanguageManager')
        ->addArgument(new Reference('request'))
        ->setScope('request');
--- 103,114 ----

      $container->register('dispatcher', 'Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher')
        ->addArgument(new Reference('service_container'));
+     $container->register('controller_resolver', 'Drupal\Core\ControllerResolver')
        ->addArgument(new Reference('service_container'));
      $container->register('http_kernel', 'Drupal\Core\HttpKernel')
        ->addArgument(new Reference('dispatcher'))
        ->addArgument(new Reference('service_container'))
+       ->addArgument(new Reference('controller_resolver'));
      $container->register('language_manager', 'Drupal\Core\Language\LanguageManager')
        ->addArgument(new Reference('request'))
        ->setScope('request');
webchick’s picture

Issue tags: +Novice

Should be a pretty easy re-roll, too.

fabpot’s picture

Status: Needs work » Needs review
FileSize
1.23 KB

Re-uploaded the patch the should apply cleanly on current 8.x

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Great :)

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.