Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The controller resolver service in Symfony is named "controller_resolver
" instead of resolver
. For better interoperability, using the same name in Drupal would help a lot. Also, as we can imagine having more than one resolvers, having a more descriptive is nice added bonus.
Proposed resolution
The patch renames the service from "resolver
" to "controller_resolver
".
Comment | File | Size | Author |
---|---|---|---|
#6 | resolver-rename.patch | 1.23 KB | fabpot |
controller_resolver.patch | 1.08 KB | fabpot | |
Comments
Comment #1
Crell CreditAttribution: Crell commentedMakes sense to me.
Comment #2
webchickRe-assigning as a task. This doesn't seem to apply for me though.
Comment #3
webchickcontroller_resolver.patch queued for re-testing.
Comment #4
webchickThis no longer applies for me. Here's the .rej file:
Comment #5
webchickShould be a pretty easy re-roll, too.
Comment #6
fabpot CreditAttribution: fabpot commentedRe-uploaded the patch the should apply cleanly on current 8.x
Comment #7
aspilicious CreditAttribution: aspilicious commentedGreat :)
Comment #8
catchCommitted/pushed to 8.x, thanks!