Couple of features added [#1873900]

Hi,

I've created a patch that fixes the bugs:

- warnings during calculating sizes of local images,
- inability to caption images added with Insert.

For size calculation it uses urldecode to change URL-encoded characters from src attribute into acceptable by filesystem and uses internal Drupal functions to make local paths public or private URLs instead of distinguishing between local and remote resources – it just makes everything URL-s, but in case of local files these are public:// or private:// -style URL-s (depends on site configuration).

For Insert-compatibility I've included changes proposed by Arshad Chummun (see http://drupal.org/node/1666792).

Besides that I've added couple of things:

- mangling img tag by adding captioned-image class – helpful in combination with lightbox2 and similar,
- automatic copying caption from title attribute of img tag if it exists and the given caption is empty,
- automatic linking to the original version (sensitive to large_, big_, medium_, small_, thumb_, thumbnail_ prefixes).

Comment	File	Size	Author
#3	caption_filter-couple_fixes_and_improvements-1873900-3.patch	7.07 KB	siefca
#2	caption_filter-couple_fixes_and_improvements-1873900-2.patch	5.58 KB	siefca
#1	caption_filter-couple_fixes_and_improvements-1873900-1.patch	5.51 KB	siefca

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

siefca CreditAttribution: siefca commented 25 December 2012 at 16:36

File	Size
caption_filter-couple_fixes_and_improvements-1873900-1.patch	5.51 KB

Comment #2

siefca CreditAttribution: siefca commented 25 December 2012 at 17:55

File	Size
caption_filter-couple_fixes_and_improvements-1873900-2.patch	5.58 KB

Updated (small fix in case of empty object).

Comment #3

siefca CreditAttribution: siefca commented 7 January 2013 at 01:03

File	Size
caption_filter-couple_fixes_and_improvements-1873900-3.patch	7.07 KB

New patch.

Features:

fixed the cause of warnings during calculating sizes of local images,
added ability to caption images added with Insert,
added decorating img attributes with captioned-image class (useful with Lightbox),
added automatic size calculation for public and private images,
added explicite and automatic linking:
- [caption link="1"] or [caption link="true"] causes automatic linking to original image;
- [caption link="some_link"] causes captioned object to link to a given resource,
added support for image styles (Drupal 7) – when automatic linking is in use the original image path is determined using proper functions,
added support for popular IMCE generated image versions – when automatic linking is in use the original image filename is determined by cutting off common prefixes like thumb_, thumbnail_ etc.

Comment #4

kmonty

San Francisco, CA

CreditAttribution: kmonty commented 7 April 2013 at 05:10

This issue partially duplicates #1937616: Notice: Undefined variable: width in _caption_filter_get_width()

Comment #5

kmonty

San Francisco, CA

CreditAttribution: kmonty commented 10 April 2013 at 15:21

Version:	7.x-1.2	» 7.x-1.x-dev
Status:	Needs review	» Closed (won't fix)

First off, I'd like to thank you for putting forth the time + effort into patching up Caption Filter!

However, I am reluctant to consider it. It's a Drupal community standard to break apart each issue into its own issue and patch, to make it easier for the community + maintainers to consider the code, bug, and fix. With so many issues in one patch, it's difficult for me to make a quick judgment and go from there--especially for new features (that aren't bug fixes), such as the linking functionality you developed (.

Plus, many of these issues that you discuss have been fixed in other issues, using patches that were submitted with their queues.

There's clearly some good stuff here, but many of the issues + features merit further discussion and development, and tackling all that in one thread would be messy. So, if you feel that some of these bugs + feature requests are important, please break them out into separate tickets so we can discuss and go from there.

Thank you!