Problem/Motivation

When creating some third-party Drupal modules, it is possible to register some new services. But if a service depends on the kernel, the request, or the service_container, it won't work as they are not declared as synthetic and they are not yet available when building the container.

Proposed resolution

This patch registers these missing synthetic services.

CommentFileSizeAuthor
#10 kernel_registration_10.patch1.12 KBfabpot
#7 kernel_registration_7.patch1.69 KBfabpot
#3 kernel_registration_3.patch1.05 KBfabpot
kernel_registration.patch1.03 KBfabpot
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Active » Needs review
fabpot’s picture

fabpot CreditAttribution: fabpot commented
Issue summary: View changes

updated description

Status: Needs review » Needs work

The last submitted patch, kernel_registration.patch, failed testing.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Title: The kernel service should be available to other services » Added some missing synthetic services that were missing
Status: Needs work » Needs review
FileSize
kernel_registration_3.patch1.05 KB
fabpot’s picture

fabpot CreditAttribution: fabpot commented
Issue summary: View changes

tweaked description

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Makes sense

Crell’s picture

Crell CreditAttribution: Crell commented

I think some of those are already registered elsewhere in CoreBundle or drupal_container(), aren't they? I'm sure request is there somewhere...

Crell’s picture

Crell CreditAttribution: Crell commented
Issue tags: +symfony, +Dependency Injection (DI)

Tagging

fabpot’s picture

fabpot CreditAttribution: fabpot commented
FileSize
kernel_registration_7.patch1.69 KB

You are right. I've just uploaded a new patch where synthetic services are registered in CoreBundle (which probably makes more sense).

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Needs work

I will be audacious and set a fabpot patch to CNW :) but it misses the classes from the registration. It's much nicer to register with a class because then it's documented in the compiled container, IDE integration whatnot.

Ie. compare the removed$container->register('class_loader', 'Symfony\Component\ClassLoader\UniversalClassLoader')->setSynthetic(TRUE); to $container->register('class_loader')->setSynthetic(TRUE);.

katbailey’s picture

katbailey CreditAttribution: katbailey commented

Actually DrupalKernel seems to me like a better place for the 'kernel', 'service_container' and 'class_loader' services because each of them will get set (either by the kernel itself or by the container in the case of service_container) regardless of what happens in CoreBundle.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Needs work » Needs review
FileSize
kernel_registration_10.patch1.12 KB

The new patch takes into account the comments.

katbailey’s picture

katbailey CreditAttribution: katbailey commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated the description to better explain the problem.