Found a minor bug:

If the system module Database logging is not enabled, update 7005 will fail, not allowing the remaining updates to complete. The simple fix is to enable Database logging. Might consider adding a check to see if that module is enabled first when running 7005 because it won't need to remove anything from the watchdog table if the table doesn't even exist to remove anything from.

I realize that the majority will have Database logging enabled but sometimes it gets overlooked (as in my case)...

#2 1871852_ensure_table_exists_before_deleting.patch551 bytesgreggles
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


philsward’s picture

More specifically the check should probably see if the "watchdog" table even exists and if not, skip the 7005 update. As it is, it just errors out saying that it can't find the watchdog table because it doesn't exist and none of the remaining updates seemed to run.

greggles’s picture

Title: Database Upgrade 7005 Error » Check if database logging is enabled before running database upgrade 7005
Status: Active » Needs review
551 bytes
PASSED: [[SimpleTest]]: [MySQL] 11 pass(es). View

Making the title more explicit with what needs to happen.

philsward’s picture

#2 Patch worked perfect for me.

DamienMcKenna’s picture

Status: Needs review » Reviewed & tested by the community

Gah, thanks greggles.

Once #1798294: Can't edit non-current node revisions is resolved I'll commit this.

Dave Reid’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.