Found a minor bug:

If the system module Database logging is not enabled, update 7005 will fail, not allowing the remaining updates to complete. The simple fix is to enable Database logging. Might consider adding a check to see if that module is enabled first when running 7005 because it won't need to remove anything from the watchdog table if the table doesn't even exist to remove anything from.

I realize that the majority will have Database logging enabled but sometimes it gets overlooked (as in my case)...

CommentFileSizeAuthor
#2 1871852_ensure_table_exists_before_deleting.patch551 bytesgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

philsward’s picture

philsward CreditAttribution: philsward commented

More specifically the check should probably see if the "watchdog" table even exists and if not, skip the 7005 update. As it is, it just errors out saying that it can't find the watchdog table because it doesn't exist and none of the remaining updates seemed to run.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Title: Database Upgrade 7005 Error » Check if database logging is enabled before running database upgrade 7005
Status: Active » Needs review
FileSize
1871852_ensure_table_exists_before_deleting.patch551 bytes

Making the title more explicit with what needs to happen.

philsward’s picture

philsward CreditAttribution: philsward commented

#2 Patch worked perfect for me.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Reviewed & tested by the community

Gah, thanks greggles.

Once #1798294: Can't edit non-current node revisions is resolved I'll commit this.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Reviewed & tested by the community » Fixed

Committed #2 to 7.x-1.x.
http://drupalcode.org/project/metatag.git/commit/6e56165

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.