processDefinition() is not part of PluginManagerInterface. The only reason it's public in PluginManagerBase is because ProcessDecorator needs to be able to call it. Here's a workaround to that.

CommentFileSizeAuthor
#25 1871710-25.patch2.61 KBsahil.goyal
#9 drupal_1871710_9.patch2.57 KBXano
#9 interdiff.txt1.05 KBXano
#8 drupal_1871710_8.patch10.79 KBXano
#6 drupal_1871710_6.patch2.56 KBXano
plugins-protect-processdefinition.patch9.32 KBeffulgentsia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Note that PHP 5.4 allows closures to access $this and its corresponding private/protected members, but D8 still needs to support PHP 5.3.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

o_O

That is... sneaky.

yched’s picture

yched CreditAttribution: yched commented

Lol, same face as @tim.plunkett.
I'm not sure why it's a problem that processDefinition() is public, but the cure, although smart, looks way uglier than the disease :-p

Status: Needs review » Needs work

The last submitted patch, plugins-protect-processdefinition.patch, failed testing.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Agreed that this still needs work. In general, the problem with methods being public is that you're then locked into them during an entire major release. Though that may also be true for protected methods in base classes intended for contrib to extend.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Triquanta commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
drupal_1871710_6.patch2.56 KB

.

Status: Needs review » Needs work

The last submitted patch, 6: drupal_1871710_6.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Triquanta commented
Status: Needs work » Needs review
FileSize
drupal_1871710_8.patch10.79 KB

.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at Triquanta commented
FileSize
interdiff.txt1.05 KB
drupal_1871710_9.patch2.57 KB

The patch from #8 contains a recent core commit. This is the correct one.

Xano queued 9: drupal_1871710_9.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: drupal_1871710_9.patch, failed testing.

Status: Needs work » Needs review

Xano queued 9: drupal_1871710_9.patch for re-testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Patch no longer applies.

If still needed.

sahil.goyal’s picture

sahil.goyal CreditAttribution: sahil.goyal as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
1871710-25.patch2.61 KB

As commented #24 patch was too old and doesn't get applies for the version 9.4.x-dev, updating the reroll of the patch, Not known that why i'm not able to upload intera_diff/Diff_reroll so sorry for that.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Version: 9.4.x-dev » 10.1.x-dev
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
CreditAttribution: elber at CI&T commented

Hi @sahil.goyal don't worry we can fix it together I will try to do a rerrol and after that you can to review

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

#25 applies cleanly for 10.1 currently running the tests.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Postponed (maintainer needs more info)

Before anyone spends more time fixing the patch wonder if this is still wanted? Been 10 years since it was brought up.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing this as outdated as there hasn't been a follow up in 5 months. if still a valid task please reopen updating the issue summary with a proposed solution, remaining tasks, api changes, etc.

Thanks