False positives in _msnf_element_required(). [#1870750]

Often, the query string (appending ?step={STEP_NAME} seems to be ignored. I have a few test environments and it is working in some sometimes, and not others at all. Can you give me a pointer as to what to look at, where to debug? I can send you whatever info you'd like, I am having the issue right now, but as you can tell, I can't reliably reproduce it.

Comment	File	Size	Author
#1	manage fields.png	128.4 KB	thatjustin
#1	request with query string.png	80.55 KB	thatjustin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

thatjustin CreditAttribution: thatjustin commented 19 December 2012 at 23:22

File	Size
request with query string.png	80.55 KB
manage fields.png	128.4 KB

Screenshots attached.

Comment #2

thatjustin CreditAttribution: thatjustin commented 20 December 2012 at 03:19

Title:

Sometimes the query string doesn't function

» Requests to specific steps fail when accessed via the query string method.

I spent more time on this issue, and I can reliably reproduce it now. Unlike other fields, if a node's body field is required, and has data, it still can't be skipped via the query string. That is why I saw it originally as sometimes, I was testing with body having data and empty, not realizing it was relevant. I'm fairly certain that the actual bug is in _msnf_element_required($form, $element), perhaps it's recursive handling of $form['body'['und'] ] but I couldn't find it precisely.

I did test this out on a clean install of msnf 7.x-1.3, core 7.17, and reliably reproduced it so that whether or not the body field had data, if it was marked as required, it wouldn't be skipped when accessed via the query string method. (Unlike other fields that would be skipped if they had data, even if required)

I really like this module, it's exactly what I was looking for, hopefully this will save someone else some headache if they encounter this issue.

Comment #3

stBorchert

he/him

German

CreditAttribution: stBorchert commented 3 January 2013 at 13:34

Title:	Requests to specific steps fail when accessed via the query string method.	» False positives in _msnf_element_required().
Version:	7.x-1.3	» 7.x-1.x-dev
Status:	Active	» Needs work

Seems like the function _msnf_element_required() does not work for all field types.
Currently body-fields and link fields (Link; reported in #1873604: Unable to skip fields of link type) are not handled correctly.