Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We are having some performance issues with some of our views. After debugging this, I have determined that the cause is from duplicate joins are getting added from the lack of redundancy checks being made within the ensure_path method of the views_plugin_query_default.inc file. There already is a redundancy check within the ensure_table, but this should also apply to ensure_path as well to better protect this from occurring. Currently we are seeing this within a Drupal 6 site and the following patch applies to 6.x branch, but this should probably be ported into 7.x as well depending on if you guys think this logic is sound.
Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1870452-views_fix_duplicate_table_joins-4.patch | 4.16 KB | travist |
| #1 | 1870452-views_fix_duplicate_table_joins-2.patch | 4.15 KB | travist |
Comments
Comment #1
travist CreditAttribution: travist commentedHere is the patch for 6.x-3.0.
Comment #3
travist CreditAttribution: travist commentedHere is a re-roll of this patch against 6.x-3.x. Let's hope the test runs are better on this one.
Comment #4
travist CreditAttribution: travist commentedComment #5
travist CreditAttribution: travist commentedComment #7
travist CreditAttribution: travist commented#3: 1870452-views_fix_duplicate_table_joins-4.patch queued for re-testing.
Comment #8
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue