Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
API page: http://api.drupal.org/api/drupal/includes%21form.inc/function/batch_set/6
The progress message that appears just below the progress bar indicator accepts a string that has the following placeholders:
- @current
- @remaining
- @total
- @percentage
- @estimate
- @elapsed
@estimate and @elapsed do not work in D6 but do work in D7. Please update documentation accordingly.
Comment | File | Size | Author |
---|---|---|---|
#7 | batch_set-invalid_placeholders-1869642-7.patch | 1.85 KB | kerasai |
#5 | batch_set-invalid_placeholders-1869642-5.patch | 1.85 KB | kerasai |
#3 | batch_set-invalid_placeholders-1869642-3.patch | 909 bytes | kerasai |
Comments
Comment #1
kerasai CreditAttribution: kerasai commentedComment #2
jhodgdonGood catch! Probably this was a backported patch that contained inappropriate information. You are correct -- you can see in the function _batch_process() in batch.inc that in D6 those two placeholders are not defined as they are in Drupal 7. We just need a quick patch to fix this in the documentation.
Comment #3
kerasai CreditAttribution: kerasai commentedDidn't realize it was that easy.
Comment #4
jhodgdonYes, it's that easy! Thanks for the patch!
The only problem I see is that the first line has an extra space at the end. You can probably set up your text editor either to remove or at least highlight end-of-line spaces to avoid this problem in your (hopefully!) future Drupal patches.
Comment #5
kerasai CreditAttribution: kerasai commentedOk, re-do. Looks like the editor picked up a couple of other lines with trailing white space as well.
Comment #6
kerasai CreditAttribution: kerasai commentedComment #7
kerasai CreditAttribution: kerasai commentedAnd of course #5 messed up the actual documentation I was trying to fix. Here's another.
Comment #8
jhodgdonThanks! Looks good -- we'll get it committed shortly.
Comment #9
jhodgdonCommitted -- thanks again for reporting and patching!