API page: http://api.drupal.org/api/drupal/includes%21form.inc/function/batch_set/6

The progress message that appears just below the progress bar indicator accepts a string that has the following placeholders:

  • @current
  • @remaining
  • @total
  • @percentage
  • @estimate
  • @elapsed

@estimate and @elapsed do not work in D6 but do work in D7. Please update documentation accordingly.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kerasai’s picture

Title: Progress Message Placeholders Incorrect » Batch API Progress Message Placeholders Invalid
Issue tags: +Batch API
jhodgdon’s picture

Issue tags: -Batch API +Novice

Good catch! Probably this was a backported patch that contained inappropriate information. You are correct -- you can see in the function _batch_process() in batch.inc that in D6 those two placeholders are not defined as they are in Drupal 7. We just need a quick patch to fix this in the documentation.

kerasai’s picture

Status: Active » Needs review
FileSize
909 bytes

Didn't realize it was that easy.

jhodgdon’s picture

Status: Needs review » Needs work

Yes, it's that easy! Thanks for the patch!

The only problem I see is that the first line has an extra space at the end. You can probably set up your text editor either to remove or at least highlight end-of-line spaces to avoid this problem in your (hopefully!) future Drupal patches.

kerasai’s picture

Ok, re-do. Looks like the editor picked up a couple of other lines with trailing white space as well.

kerasai’s picture

Status: Needs work » Needs review
kerasai’s picture

And of course #5 messed up the actual documentation I was trying to fix. Here's another.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks! Looks good -- we'll get it committed shortly.

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Committed -- thanks again for reporting and patching!

Automatically closed -- issue fixed for 2 weeks with no activity.