After enabling the module and entering info into /admin/config/services/youtubechannel I get the following JS error:

TypeError: href is undefined
youtubeid = href.replace("#","");

CommentFileSizeAuthor
#4 1869606-href-underfined.patch1.37 KBdgtlmoon

Comments

parwan005’s picture

parwan005 commented
Status: Active » Closed (fixed)

I believe this one is no longer an issue.

adraskoy’s picture

adraskoy commented
Status: Closed (fixed) » Active

I am seeing this on some pages, particularly the media gallery "add media" browser, which is destroyed by this error.

adraskoy’s picture

adraskoy commented

Just adding a check for a null href seems to fix the problem.

+ if (href) {
      youtubeid = href.replace("#","");
      jQuery('#youtubechannel-frame').attr('src','http://www.youtube.com/embed/' + youtubeid);
+ }
dgtlmoon’s picture

dgtlmoon commented
Issue summary: View changes
StatusFileSize
new 1869606-href-underfined.patch1.37 KB

Patch supplied, also cleans up bad selectors

Patch deals with it by not running the function if it's not required, so theres no bad href passed in the first place

dgtlmoon’s picture

dgtlmoon commented
Status: Active » Needs review

  • Commit f886b0a on 7.x-2.0 by parwan005: 
    Fixes for Issue #1983774, #1939138, #2041111, #1869606, #2032839.
parwan005’s picture

parwan005 commented
Version: 7.x-2.0 » 7.x-2.1

Have tried to fix the issue in latest release.
I hope users will not have to face issue again.

parwan005’s picture

parwan005 commented
Status: Needs review » Fixed
parwan005’s picture

parwan005 commented
Status: Fixed » Closed (fixed)