Bad Calendar View arguments result in PHP errors

Moving to the correct project.

I was misled by the title. However, I do think calendar module should handle checking what it passes to theme('table'). PHP may be sloppy about typing, but we try not to encourage it.

I have the exact same problem with foreach() error. it's all over the boards. what is the best resolution - note i do have arguments with calendar view?

thanks!

Is this still a problem in the 5.2 version? I don't see it.

Yes, this is a problem at groups.d.o right now.

I don't know of any place where I would be passing something that might not be an array to theme table, and I can't replicate the problem, so I don't know where it is coming from. Is anyone in a place where they can do a debug_backtrace to figure out what function this is coming from?

So I was reading some of http://drupal.org/node/171843 and noticed they were talking about the previous/next links. So I figure why not make a check for the array that is being sent to theme_table(). Line 327 of calendar.theme seemed to have just an array being sent without any processing, so I made the following change.

Original

function theme_calendar_nav_wrapper($array) {
  return theme('table', $array, array());
}

Revised

function theme_calendar_nav_wrapper($array) {
  return theme('table', is_array($array) ? $array : array(), array());
}

And now I don't have any errors being written in my log. I noticed that the kind of URLs that were generating these errors was in the form of http://www.example.com/events/73/2008/01/15. Notice the "73" right after the events, well that brought me to a page with the date of Friday, April 1 2140. Don't ask me why but with this fix, the previous/next links do not show up anymore on pages that have that kind of URL. I'm assuming search engine bots are going through the site and getting to very far dates away from now and is causing all the problems. Well, once the bot gets to a page that either the calendar or date module can't handle, it doesn't produce the previous/next links anymore to let it go further. Just my theory anyways.

I will update you all if I continue to not have any messages written to my log.

I have not found any errors in my log as of today, so I believe the code I submitted fixed the problem.

Thanks for the help identifying this. This helped me figure out where something that went to that function might not always be an array. I made a different fix and committed it to 5.x, 5.2.x, and HEAD. Please reopen if the fix I committed doesn't work and I'll at least come back and cast this as an array.

Worked for me too. I was seeing crazy amounts of errors on this one. I suspect from a crawler or something.