The main fields defined in og_og_fields_info() have description strings for each field that describe what the field *does* once it exists on the entity, eg:

'description' => t('Determine if this should be a group.'),
'description' => t('Determine if group should use default roles and permissions.'),

However, those in og_access_og_fields_info() are phrased as an action from the point of view of adding that field to the entity type:

'description' => t('Add Group access field to group types.'),
'description' => t('Add Group access field to group-content types, that may override the group settings.'),

This is confusing. These should be changed so they read in the same way, so something like:

'description' => t('Determine access to the group.'),
'description' => t('Determine access to the group content, which may override the group settings.'),

#1 1865824.og_.og_access_og_fields_info-descritions.patch1010 bytesjoachim
PASSED: [[SimpleTest]]: [MySQL] 731 pass(es).
[ View ]


joachim’s picture

Status:Active» Needs review
new1010 bytes
PASSED: [[SimpleTest]]: [MySQL] 731 pass(es).
[ View ]

Here's a patch with that change.

amitaibu’s picture

Status:Needs review» Fixed

Committed, thanks.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

clearer explanation