It would be nice to be able to force the user to login on the login page. I'm adding a patch that does just that.

CommentFileSizeAuthor
#5 commerce_extra-force-login-1865056-5.patch1.88 KB5n00py
#4 commerce_extra-force-login-1865056-4.patch1.71 KBbennybobw
#2 issue-1865056.txt1.12 KBspiffl
#1 commerce_extra-force-login-1865056-2.patch1.47 KBbennybobw
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bennybobw’s picture

bennybobw CreditAttribution: bennybobw commented
Status: Active » Needs review
FileSize
commerce_extra-force-login-1865056-2.patch1.47 KB

Here's a small patch.

spiffl’s picture

spiffl CreditAttribution: spiffl commented
FileSize
issue-1865056.txt1.12 KB

I was having difficulties to apply the patch by bennybobw so here's the same thing rewritten in plain text with a minor adjustment.

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu commented
Status: Needs review » Needs work

Hmm, that looks almost good, but I think we need to remove the new variable (commerce_extra_login_page_force_login) when uninstalling the module.

bennybobw’s picture

bennybobw CreditAttribution: bennybobw commented
Status: Needs work » Needs review
FileSize
commerce_extra-force-login-1865056-4.patch1.71 KB

Fixed my patch issue. Here's the rerolled patch

5n00py’s picture

5n00py CreditAttribution: 5n00py commented
Status: Needs review » Needs work
FileSize
commerce_extra-force-login-1865056-5.patch1.88 KB

I fixed patch (formatting and file paths).
When I uncheck setting, form still require login. It need to be fixed.