Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
According to the documentation https://dev.twitter.com/docs/cards the image tag should use meta but a link is generated instead.
The current code generates:
<link property="twitter:image" content="https://example.com/test.png" />
It should output:
<meta property="twitter:image" content="https://example.com/test.png" />
Comment | File | Size | Author |
---|---|---|---|
#2 | metatag-n1864340.patch | 2.29 KB | DamienMcKenna |
#1 | metatag-twitter_card_fix-1864340-1.patch | 1 KB | cdoyle |
Comments
Comment #1
cdoyle CreditAttribution: cdoyle commentedLine 125 of the metatag_twitter_cards.metatag.inc should use 'DrupalTextMetaTag' instead of 'DrupalLinkMetaTag'.
Comment #2
DamienMcKennaAh, I used DrupalLinkMetaTag instead of DrupalTextMetaTag for several items. Looking at it further, I think the classes are incorrectly named, but that's a different issue.
Comment #3
cdoyle CreditAttribution: cdoyle commentedYeah, that very well could be. I was only using twitter:image so that's the only one I noticed/patched but it does look like there are other instances.
Comment #4
DamienMcKennaCommitted! Thanks for finding this, cdoyle.