Follow-up to: #1849480: Allow ConfigEntity classes to control how they are saved

Problem

  • EntityInterface::getExportProperties() contains "export" and "export" is a veeery ambiguous term, at least within the config entity space.

Goal

  • Find a method name that does not conflict with other import/export concepts.

Details

  • "export" and "import" carry some (too) huge meaning.
  • "serialize" and "normalize" come closest, but are taken by new REST stuff already.
  • getExportProperties() itself is barely different from the pre-existing getProperties() method.

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

So, getProperties() implies you'd return an array of properties, like

$values = array();
foreach ($entity->getProperties() as $property) {
 $values[$property] = $entity->get($property);
}

But the return of this includes the built values as well. So maybe not properties at all?

Also, as the person who named getExportProperties() (with not much real thought behind it) I'm +1 to renaming it.

yched’s picture

yched CreditAttribution: yched commented

getStoredProperties() ? getStoredValues() ?

yched’s picture

yched CreditAttribution: yched commented
Issue summary: View changes

Updated issue summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Issue summary: View changes
Status: Active » Closed (duplicate)

toArray() happened :)