The patch in #594660: Rename default menu names the 'block-menu' class as well as the 'role="navigation"' property to no longer appear on system menu blocks. (@see system_preprocess_block() ... the part in 'default:' in the switch never evaluates to TRUE because the block delta always has a 'menu-' prefix while the output of menu_list_system_menus() doesn't.

Files: 
CommentFileSizeAuthor
#3 1863180-3.patch2.03 KBfubhy
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863180-3.patch. Unable to apply patch. See the log in the details link for more information. View
system-menu-block.patch767 bytesfubhy
PASSED: [[SimpleTest]]: [MySQL] 49,280 pass(es). View

Comments

tim.plunkett’s picture

Issue tags: +Needs tests

This needs tests, but it will also break #1535868: Convert all blocks into plugins.
Maybe postpone it til after that?

sun’s picture

Title: Regression for system menu blocks. Currently rendered without 'role="navigation"' and 'menu-block' class. » System menu blocks lack role="navigation" and .block-menu class
Issue tags: +regression

The patch looks good. Let's add a quick and simple assertion line to an existing (System) menu test (hopefully there are some) and get this fixed.

fubhy’s picture

FileSize
2.03 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 1863180-3.patch. Unable to apply patch. See the log in the details link for more information. View

We don't have a 'system' menu test. So I put this into the block test... Not sure if that's the right place for this because, well, its a system module block. But I didn't want to add a new test just for this simple assertion.

Status: Needs review » Needs work

The last submitted patch, 1863180-3.patch, failed testing.

fubhy’s picture

Yeah right...

fubhy’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests, -regression

#3: 1863180-3.patch queued for re-testing.

alansaviolobo queued 3: 1863180-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 1863180-3.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.