Seen on every page when my Aurora sub-theme is active.

Files: 
CommentFileSizeAuthor
#2 1862858-uasort-notice.patch4.12 KBgoogletorp
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1862858-uasort-notice.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

iamcarrico’s picture

I will look into this, and #1862860: Notice: Undefined index: type in aurora_get_js_old(). Quick question--- what version of PHP are you running? (not sure if it will affect it, but this seems like something in that direction)

googletorp’s picture

Status: Active » Needs review
FileSize
4.12 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1862858-uasort-notice.patch. Unable to apply patch. See the log in the details link for more information. View

The problem is that Aurora assumes that certain js files will exist and alters a few things about them. On some pages if one or more of these js files is removed by a Drupal module, it will result in a lot of notices. The fix is to check that the js Aurora wants to alter actually exists before doing so.

Status: Needs review » Needs work

The last submitted patch, 1862858-uasort-notice.patch, failed testing.

iamcarrico’s picture

@googletorp, all of those javascript files should always be present... as they are required by Drupal core. I think some of the most recent code to the dev branch fixes this, but I am doing some more testing first.

iamcarrico’s picture

Status: Needs work » Closed (fixed)

Closing issue--- seems to be fixed.