Link text is always displayed due to using isset() for checking config option.

CommentFileSizeAuthor
#3 views_timelinejs_link_text-1860744-3.patch782 bytesimclean
views_timelinejs-link_text.patch717 bytesimclean
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FluxSauce’s picture

FluxSauce CreditAttribution: FluxSauce commented

How about:

isset($this->options['timeline_config']['link_text_enabled']) && $this->options['timeline_config']['link_text_enabled']

This way, it handles unset or no value gracefully and then checks for a non false/null value.

imclean’s picture

imclean CreditAttribution: imclean commented

Sounds fine. I guess we shouldn't assume even a mandatory field has a value. Although it will have a value one way or the other as soon as the config form is saved for the first time.

imclean’s picture

imclean CreditAttribution: imclean commented
FileSize
views_timelinejs_link_text-1860744-3.patch782 bytes

Done.

operinko’s picture

operinko CreditAttribution: operinko commented
Status: Needs review » Fixed

And this is what you get when you fix old issues in a hurry :(
Good catch, applied the patch and attributed imclean.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.