Here for the community? On May 9th, we'll be in New Orleans. Don’t miss out!
Link text is always displayed due to using isset() for checking config option.
isset($this->options['timeline_config']['link_text_enabled']) && $this->options['timeline_config']['link_text_enabled']
This way, it handles unset or no value gracefully and then checks for a non false/null value.
Sounds fine. I guess we shouldn't assume even a mandatory field has a value. Although it will have a value one way or the other as soon as the config form is saved for the first time.
And this is what you get when you fix old issues in a hurry :(
Good catch, applied the patch and attributed imclean.
Automatically closed -- issue fixed for 2 weeks with no activity.
Drupal is a registered trademark of Dries Buytaert.