A minor issue, but the getInfo() method in the HierarchicalSelectInternals class should have a static declaration. call_user_func() on line 327 of simpletest.module calls the class/method statically.

The enclosed patch fixes this minor issue.

CommentFileSizeAuthor
getInfo_should_be_static-Unknown-1.patch466 bytessdrycroft
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brad.bulger’s picture

brad.bulger CreditAttribution: brad.bulger commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Applied to 3.0-beta8 and it fixes the complaint from SimpleTest

Strict warning: call_user_func() expects parameter 1 to be a valid callback, non-static method HierarchicalSelectInternals::getInfo() should not be called statically in simpletest_test_get_all() (line 372 of /path/to/docroot/modules/simpletest/simpletest.module).

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: Unassigned » andrey.troeglazov

  • andrey.troeglazov committed 1970744 on 7.x-3.x 
    Issue #1860000 by sdrycroft, brad.bulger, andrey.troeglazov: getInfo()...
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: andrey.troeglazov » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.