I just ran the tests for the latest 7.x-1.x branch. Result: 48 fails.

It is perhaps a good idea to start with automatically testing each patch that is posted, so that new patches are not committed that break existing functionality.

CommentFileSizeAuthor
#1 1858440-1-purl-broken_tests.patch1.51 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Active » Needs review
FileSize
1858440-1-purl-broken_tests.patch1.51 KB

I've looked into this. When I run the tests on my machine the results are not so dramatic. I get 8 fails and 14 exceptions.

I have been able to fix all problems, but the broken language prefixes are caused by a bug in the Locale module. If you apply the patch from comment #5 of #1270894: Test that it is possible to use path prefixes in combination with language prefixes all tests are green.

This patch fixes the following:

  • Exceptions (strict warnings) under PHP 5.4
  • Pair prefixer does not prefix to existing path prefixer, but appends to it, breaking the 'Path + Pair' test.