We should use .once() so that we only help icon.

Before the patch:
Screen Shot 2012-12-03 at 16.41.48.png

After the patch:
Screen Shot 2012-12-03 at 16.41.00.png

CommentFileSizeAuthor
#2 devel-use_once_for_krumo_path-1857130-2.patch708 bytesyannickoo
#1 devel-use_once_for_krumo_path-1857130-1.patch698 bytesyannickoo
Screen Shot 2012-12-03 at 16.41.00.png15 KByannickoo
Screen Shot 2012-12-03 at 16.41.48.png14.78 KByannickoo

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new devel-use_once_for_krumo_path-1857130-1.patch698 bytes
yannickoo’s picture

yannickoo
Location Berlin
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
StatusFileSize
new devel-use_once_for_krumo_path-1857130-2.patch708 bytes

I also attached the patch for the 8.x branch.

salvis’s picture

salvis
he/his
commented

Hmm, strange, I've never seen that. How can I reproduce it?

Thank you for your post and patches. donquixote is rewriting krumo in #1853112: Replacement for Krumo?, but this is small enough to still get in.

yannickoo’s picture

yannickoo
Location Berlin
commented

This appears when you do some AJAX things so that all Drupal.attachBehaviors() will be executed.

salvis’s picture

salvis
he/his
commented

This looks good to me. I'd like someone to actually test it...

yannickoo’s picture

yannickoo
Location Berlin
commented

I made a quick screencast where you can see the problem :)

juampynr’s picture

juampynr commented
Issue tags: +develcontribute

Adding develcontribute tag.

yannickoo’s picture

yannickoo
Location Berlin
commented

Currently the video is deleted. I hope you saw it... But it is very use to reproduce.

salvis’s picture

salvis
he/his
commented

devel_krumo_path.js has been moved to the js subdirectory in D8, so I had to massage #2 a bit.

Pushed to D8 and D7 — thanks!

salvis’s picture

salvis
he/his
commented
Status: Needs review » Fixed
yannickoo’s picture

yannickoo
Location Berlin
commented

Oh, you didn't attribute authorship to me ;)

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Ouch, I always thought that 'glitch' was actually useful, so you knew if your ajax was executing by looking at the number of question icons :(

salvis’s picture

salvis
he/his
commented

I did:

Issue #1857130 by yannickoo: Fixed Use .once() for the krumo path so that you only see one help icon.

http://drupal.org/commitlog/commit/42/d833d44cb86eeca47494632fcba2456c27...
http://drupal.org/commitlog/commit/42/e00e8fcac3e2f7c7baac5b6567e3f0cbf3...

yannickoo’s picture

yannickoo
Location Berlin
commented

No, that is only the commit message but you didn't pass --author – See Adding a commit author.

salvis’s picture

salvis
he/his
commented
Issue tags: -develcontribute

@yannickoo: Yes, this is intentional. There's a thread in this queue where I gave my reasons.

@pcambra: It has been at NR for three months and it even got the develcontribute tag.

yannickoo’s picture

yannickoo
Location Berlin
commented

There's a thread in this queue where I gave my reasons.

Can you tell me where I can find this?

juampynr’s picture

juampynr commented

Here http://drupal.org/node/1799024#comment-6552676

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.