Started running a debugger for hostmaster, found a few missing 'isset's so I patched it.

diff --git a/modules/hosting/hosting.features.inc b/modules/hosting/hosting.features.inc
index 112e951..7fc7716 100644
--- a/modules/hosting/hosting.features.inc
+++ b/modules/hosting/hosting.features.inc
@@ -34,7 +34,7 @@ function hosting_feature($feature) {
   if (!sizeof($features)) {
     $features = hosting_get_features();
   }
-  if ($features[$feature]['module']) {
+  if (isset($features[$feature]['module'])) {
     $return = (module_exists($features[$feature]['module'])) ? HOSTING_FEATURE_ENABLED : HOSTING_FEATURE_DISABLED;
   }
   else {
diff --git a/modules/hosting/task/hosting_task.module b/modules/hosting/task/hosting_task.module
index 3772b81..5c7f695 100644
--- a/modules/hosting/task/hosting_task.module
+++ b/modules/hosting/task/hosting_task.module
@@ -1143,10 +1143,10 @@ function hosting_task_fetch_tasks($rid) {
     $task = array_merge($return[$type], $hook_task);
 
     $allowed = (isset($task['exists']) && !in_array($task['task_status'], array(HOSTING_TASK_QUEUED, HOSTING_TASK_PROCESSING))) || 
-    if ($allowed && !$task['hidden'] && $access_callback($node, $type)) {
+    if ($allowed && !isset($task['hidden']) && $access_callback($node, $type)) {
       $task['task_permitted'] = TRUE;
     }
-    $task['class'] = hosting_task_status_class($task['task_status']);
+    $task['class'] = hosting_task_status_class(isset($task['task_status'])? $task['task_status']: null);
 
     $return[$type] = $task;
   }
CommentFileSizeAuthor
#3 phpnotices-1855486-3.patch4.12 KBJon Pugh
#1 phpnotices-1855486.patch1.43 KBJon Pugh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh commented
FileSize
phpnotices-1855486.patch1.43 KB

attached

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Active » Needs review
Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh commented
FileSize
phpnotices-1855486-3.patch4.12 KB

Found many more.

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Needs review » Needs work 
+++ b/modules/hosting/task/hosting_task.moduleundefined
@@ -1008,7 +1008,9 @@ function hosting_task_table($node) {
+    $actions['log'] = _hosting_task_button(t('View'), isset($info['nid'])? 'node/' . $info['nid']: '<front>', t("Display the task log"), 'hosting-button-log', isset($info['nid']) &&  user_access('access task logs'), TRUE, FALSE);

@@ -1143,8 +1145,17 @@ function hosting_task_fetch_tasks($rid) {
+    } else {

Doesn't meet Drupal coding standards

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs work » Fixed

@Jon Pugh Thanks very much for the patch, applied and cleanup up in 6.x-2.x.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented

Actually this required some extra work in this patch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updating patch code

  • Commit 9663575 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1855486 by Jon Pugh: Fixed Patch to Remove some Notices.
  • Commit ba9ec47 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1855486 by Steven Jones: Fixed Patch to Remove some Notices.

  • Commit 9663575 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1855486 by Jon Pugh: Fixed Patch to Remove some Notices.
  • Commit ba9ec47 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1855486 by Steven Jones: Fixed Patch to Remove some Notices.