As I said in #1137920-276: Fix toolbar on small screen sizes and redesign toolbar for desktop, I like the change made there, but the code comment should be updated. I will supply a tiny patch as soon as I have an issue number.

CommentFileSizeAuthor
#1 toolbar-comment-1855088-1.patch675 bytesbenjifisher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
CreditAttribution: benjifisher commented
Status: Active » Needs review
FileSize
toolbar-comment-1855088-1.patch675 bytes

Patch attached. I do not think I can compete with @JohnAlbin's trivial patch contest winner.

Barnettech’s picture

Barnettech CreditAttribution: Barnettech commented
Status: Needs review » Reviewed & tested by the community

Great way to break the ice in reviewing patches, this one indeed cannot be any simpler. The code comment looks good.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +JavaScript

If the patch has JS in it, please tag it :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

lol nice. :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.