Follow up for #1810386: Create workflow to setup multilingual for entity types, bundles and fields

Problem/Motivation

#1810386-71: Create workflow to setup multilingual for entity types, bundles and fields Started an accessibility review.
#1810386-124: Create workflow to setup multilingual for entity types, bundles and fields Addressed request for label for=
This is a follow-up for ARIA and other accessibility focused investigation and careful review. This issue is for remaining accessibility work on the translation settings page. Note that some of the other usability follow-ups to that issue might also improve general accessibility and those general improvements dont need to be addressed here.

Proposed resolution

#1810386-114: Create workflow to setup multilingual for entity types, bundles and fields

Remaining tasks

  • Read ARIA docs carefully.
  • Add comments listing specific changes to make
  • Implement some, create patches
  • Get more reviews
  • Rinse. Repeat.

Find other things todo

  • Get more types of accessibility reviews, screen reader, having someone just try using the page without a mouse.
  • Get the point of view of some of the experienced accessibility reviewers in the community
  • http://drupal.org/node/1853532 doc page: Contributor task: Manually do Accessibility testing of a patch for a Drupal issue could be helpful for people wanting to jump in

User interface changes

(new or changed features/functionality in the user interface, modules added or removed, changes to URL paths, changes to user interface text)

API changes

No api changes expected.

Files: 
CommentFileSizeAuthor
#1 label-notes.txt2.92 KBYesCT

Comments

YesCT’s picture

FileSize
2.92 KB

Here is something I tried to do.

mgifford’s picture

Thanks for this @YesCT

Can you give me a bit of a better sense of what you are doing with label-notes.txt?

Hidden elements are definitely a problem (as are labels). We've made some improvements and ultimately I think we're going to have to add ARIA to provide the additional semantics to screen reader users.

YesCT’s picture

I think I need to read the links from #1810386-114: Create workflow to setup multilingual for entity types, bundles and fields.

You asked for a better sense of what I was doing with the label:

(from #1810386-100: Create workflow to setup multilingual for entity types, bundles and fields)

The intent was that it would help make it clear that the Body, was a field. Since the field column is being merged with the bundle/entitytype.
The row that is a entity type for Basic Page gets a label that says Content.
The row for a body for the Basic Page gets a label that says Content Basic Page Field.

Visually, the Fields in the merged column are indented, but I figured an indent is not meaningful for a screenreader. So that is why I added the label.

YesCT’s picture

Title: Use Label for= element-invisible in translation settings page to improve accessibility » ARIA and accessibility improvements in entity (content) translation settings page
Issue tags: +aria

repurposing for general ARIA / accessibility follow-ups.

plach’s picture

Status: Active » Postponed

Let's wait for the wizard patch to be committed.

mgifford’s picture

YesCT’s picture

mgifford’s picture

Ok, so we need to identify where other patches need to be made and try to re-roll some. We've been successful in introducing a lot of ARIA, but there's still a long ways to go.

Dragan Eror’s picture

Issue tags: +SprintWeekend2013

I've checked the Content language settings page (admin/config/regional/content-language) with ChromeVox - Screen reader (Chrome extension). And when I used sticky mode, everything was easily accessible and readable without using mouse, except options from combo boxes. ChromeVox can't read options from combo box until option is selected, but that is probably because options are part of OS not browser.

Using "role" attribute or any of "aria-" attributes would be useful if we would like to use wrapper to group some elements and inform screen readers about that, but we do not use such a grouping.
The one more case where "aria" would be useful is on tables with sortable columns which is not the case on this page.

mgifford’s picture

@Dragan, sounds great! So is there a #SprintWeekend where you are going to be able to roll up a patch?

How can we help improve the grouping elements for translation?

Also totally appreciate ideas on how to improve sortable tables too. Might make sense to just set up a new issue for that one though as tables are used so much throughout Core.

falcon03’s picture

One improvement I was thinking about is adding a live region to let blind users know that fields are shown or hidden when enabling or disabling translation for an entity bundle. @mgifford, what do you think about this?

This would be super-easy to do with the new drupalAnnounce() method :-)

mgifford’s picture

Gábor Hojtsy’s picture

Component: translation_entity.module » content_translation.module
mgifford’s picture

Issue tags: +language of parts

tagging

mgifford’s picture

Issue summary: View changes

label for= was done in the parent issue. use this for the rest.

jcnventura’s picture

Please consider also this related issue during those ARIA improvements, as it's the label for the content-type-specific content translation flag.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.