Hide language selection option is backwards

Thanks. We're dealing with two common sense violations here at the same time:

- UX: Never expose a negated checkbox.

- DX: Avoid values that have a negated meaning, because it inherently means that all conditions need to be negated, too.

FWIW:

Off-hand, I do not understand why this setting is called 'language_hidden'. Originally, I assumed this to be a UI/UX hiccup only, but after grepping + adjusting the entire code base, it appears to me that this value has a much larger meaning and consequences than just show/hide.

I almost have the impression that the tweak in this patch is incorrect — instead of 'language_show', it should probably be 'language_enabled' or something.

...and if that is the case, then I'm not sure whether I understand why this setting exists in the first place, and whether it doesn't actually duplicate some other configuration elsewhere... (?)

[At this point, it should be obvious that I'm a little lost ;)]

Pretty image plz :D And @sun is correct, its even in the handbooks at http://drupal.org/node/387526 - wish we could scan drupal for these mistakes.

Should we rename it from 'language_show' to 'language_select' then? Or 'language_user_overridable' ? :)

The new checkbox is:

[ ] Show language selector on create and edit pages

Without description.

Show just sounds a little less scary than expose :)

Fixing test cases in #9

Fixing test cases.

Updating asset text.

Sometimes interdiff'ing to specific patches in the past is helpful. (like the interdiff to 11)
A plain interdiff to whatever the most recent patch is should also usually be included.

I'm guessing you can just do that next time, just interdiff back to the most recent patch.

Hopefully node.install change fix test case issue.

Hi @Gábor Hojtsy , thank you for your review. Except below one, we are good with other parts (i.e. we have replace FALSE as TRUE and TRUE as FALSE):

   public function testLanguageConfigurationElement() {
     $this->drupalGet('language-tests/language_configuration_element');
     $edit['lang_configuration[langcode]'] = 'current_interface';
-    $edit['lang_configuration[language_hidden]'] = TRUE;
+    $edit['lang_configuration[language_show]'] = TRUE;
     $this->drupalPost(NULL, $edit, 'Save');
     $lang_conf = language_get_default_configuration('some_custom_type', 'some_bundle');

     // Check that the settings have been saved.
     $this->assertEqual($lang_conf['langcode'], 'current_interface');
-    $this->assertTrue($lang_conf['language_hidden']);
+    $this->assertTrue($lang_conf['language_show']);
     $this->drupalGet('language-tests/language_configuration_element');
     $this->assertOptionSelected('edit-lang-configuration-langcode', 'current_interface');
-    $this->assertFieldChecked('edit-lang-configuration-language-hidden');
+    $this->assertFieldChecked('edit-lang-configuration-language-show');

     // Reload the page and save again.
     $this->drupalGet('language-tests/language_configuration_element');
     $edit['lang_configuration[langcode]'] = 'authors_default';
-    $edit['lang_configuration[language_hidden]'] = FALSE;
+    $edit['lang_configuration[language_show]'] = FALSE;
     $this->drupalPost(NULL, $edit, 'Save');
     $lang_conf = language_get_default_configuration('some_custom_type', 'some_bundle');

     // Check that the settings have been saved.
     $this->assertEqual($lang_conf['langcode'], 'authors_default');
-    $this->assertFalse($lang_conf['language_hidden']);
+    $this->assertFalse($lang_conf['language_show']);
     $this->drupalGet('language-tests/language_configuration_element');
     $this->assertOptionSelected('edit-lang-configuration-langcode', 'authors_default');
-    $this->assertNoFieldChecked('edit-lang-configuration-language-hidden');
+    $this->assertNoFieldChecked('edit-lang-configuration-language-show');
   }

vs.

   public function testLanguageConfigurationElement() {
     $this->drupalGet('language-tests/language_configuration_element');
-    $edit['lang_configuration[langcode]'] = 'current_interface';
-    $edit['lang_configuration[language_hidden]'] = TRUE;
+    $edit['lang_configuration[langcode]'] = 'authors_default';
+    $edit['lang_configuration[language_show]'] = FALSE;
     $this->drupalPost(NULL, $edit, 'Save');
     $lang_conf = language_get_default_configuration('some_custom_type', 'some_bundle');

     // Check that the settings have been saved.
-    $this->assertEqual($lang_conf['langcode'], 'current_interface');
-    $this->assertTrue($lang_conf['language_hidden']);
+    $this->assertEqual($lang_conf['langcode'], 'authors_default');
+    $this->assertFalse($lang_conf['language_show']);
     $this->drupalGet('language-tests/language_configuration_element');
-    $this->assertOptionSelected('edit-lang-configuration-langcode', 'current_interface');
-    $this->assertFieldChecked('edit-lang-configuration-language-hidden');
+    $this->assertOptionSelected('edit-lang-configuration-langcode', 'authors_default');
+    $this->assertNoFieldChecked('edit-lang-configuration-language-show');

     // Reload the page and save again.
     $this->drupalGet('language-tests/language_configuration_element');
-    $edit['lang_configuration[langcode]'] = 'authors_default';
-    $edit['lang_configuration[language_hidden]'] = FALSE;
+    $edit['lang_configuration[langcode]'] = 'current_interface';
+    $edit['lang_configuration[language_show]'] = TRUE;
     $this->drupalPost(NULL, $edit, 'Save');
     $lang_conf = language_get_default_configuration('some_custom_type', 'some_bundle');

     // Check that the settings have been saved.
-    $this->assertEqual($lang_conf['langcode'], 'authors_default');
-    $this->assertFalse($lang_conf['language_hidden']);
+    $this->assertEqual($lang_conf['langcode'], 'current_interface');
+    $this->assertTrue($lang_conf['language_show']);
     $this->drupalGet('language-tests/language_configuration_element');
-    $this->assertOptionSelected('edit-lang-configuration-langcode', 'authors_default');
-    $this->assertNoFieldChecked('edit-lang-configuration-language-hidden');
+    $this->assertOptionSelected('edit-lang-configuration-langcode', 'current_interface');
+    $this->assertFieldChecked('edit-lang-configuration-language-show');
   }

As you can see, by not changing the TRUE/FALSE, but the assert part (NoField to Field and assertTrue to assertFalse), we are changing the order of test cases and It covers exactly the same it used to.

However I have committed the changes to make this patch clear and consistent with other part of this patch.

Thank you.

Regards,
Vijay.

Updating patch with review comments in #25.

Typo fix.

Nice UX clean-up. Glad we are doing user testing. Committed to 8.x.

oops. all the switching caused this #1891630: regression: show language selection option not auto checked (after fixing show/hide backwards)