It set fixed height to the icon to crop shortcut.png, therefore it looks like move up. So we apply style to move it down. and fix it to centered align.

Before:
add_remove_before.png

After:

add_remove_after.png

Also added space between icon & hover texts.

CommentFileSizeAuthor
#16 1849754_ie9.png10.6 KBRisse
#16 1849754_firefox.png12.18 KBRisse
#16 1849754_chrome.png10.89 KBRisse
#15 Chrome OSX 2013-03-09 um 13.13.11.png99.22 KBpixelmord
#15 Safari OSX 2013-03-09 um 13.13.26.png292.61 KBpixelmord
#15 Firefox OSX 2013-03-09 um 13.14.29.png282.17 KBpixelmord
#14 1849754_win7_ie9.png7.32 KBetbauer
#12 1849754_win7_firefox18.png8.72 KBetbauer
#11 1849754_ie10_win8.png6.42 KBbkonetzny
#9 184754_9_add_or_remove_and_space.patch2.52 KBkanchuraji
#6 firefox.png8.84 KBUllas Prabhakar
#6 chrome.png7.01 KBUllas Prabhakar
#6 ie8.png6.09 KBUllas Prabhakar
#5 chrome.png15.14 KBpameeela
#5 firefox.png17.02 KBpameeela
#5 IE9.png11.18 KBpameeela
add_remove_shortcut.patch1.35 KBdroplet
add_remove_after.png9.46 KBdroplet
add_remove_before.png8.74 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Needs browser testing. IE8, IE9, firefox and chrome should be enough.

droplet’s picture

droplet CreditAttribution: droplet commented
Issue tags: +Novice, +Needs manual testing
droplet’s picture

droplet CreditAttribution: droplet commented

add_remove_shortcut.patch queued for re-testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

There also should be a background image

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
IE9.png11.18 KB
firefox.png17.02 KB
chrome.png15.14 KB

Tested in Chrome, Firefox and IE9 (wasn't able to test in IE8), screenshots attached.

Chrome
chrome.png

Firefox
firefox.png

IE9
IE9.png

Ullas Prabhakar’s picture

Ullas Prabhakar CreditAttribution: Ullas Prabhakar commented
FileSize
ie8.png6.09 KB
chrome.png7.01 KB
firefox.png8.84 KB

Patch still not working, needs fixing

Firefox
firefox

Chrome
chrome

ie8
chrome

Ullas Prabhakar’s picture

Ullas Prabhakar CreditAttribution: Ullas Prabhakar commented
Status: Needs review » Needs work

changing status, needs work

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review

@ullasp85,

can you retest it ? have you clean you caches after apply patch

kanchuraji’s picture

kanchuraji CreditAttribution: kanchuraji commented
FileSize
184754_9_add_or_remove_and_space.patch2.52 KB

The above issue is also in admin seven theme without overlay. The heading alignment is also fixed with this patch. Tested in firefox browser only.

bkonetzny’s picture

bkonetzny CreditAttribution: bkonetzny commented
Issue tags: +SprintWeekend2013

Adding tag for upcoming IE tests.

bkonetzny’s picture

bkonetzny CreditAttribution: bkonetzny commented
FileSize
1849754_ie10_win8.png6.42 KB

Looks good in IE 10 (and emulated IE9 and IE8) on Windows 8 (64bit).
IE10 / Windows 8

etbauer’s picture

etbauer CreditAttribution: etbauer commented
FileSize
1849754_win7_firefox18.png8.72 KB

seems fine.
tested with win7 firefox 18.0.1
1849754_win7_firefox18.png

cgalli’s picture

cgalli CreditAttribution: cgalli commented

Tested in Chrome, Firefox, IE 9, Safari for windows.
Works fine

etbauer’s picture

etbauer CreditAttribution: etbauer commented
FileSize
1849754_win7_ie9.png7.32 KB

tested with Win7 IE9 and emulated IE8 and IE7
1849754_win7_ie9.png

pixelmord’s picture

pixelmord CreditAttribution: pixelmord commented
FileSize
Firefox OSX 2013-03-09 um 13.14.29.png282.17 KB
Safari OSX 2013-03-09 um 13.13.26.png292.61 KB
Chrome OSX 2013-03-09 um 13.13.11.png99.22 KB

Tested in OSX latest Chrome, Safari and FF.
See attached screenshots
Chrome OSX 2013-03-09 um 13.13.11.png

Safari OSX 2013-03-09 um 13.13.26.png

Firefox OSX 2013-03-09 um 13.14.29.png

Risse’s picture

Risse CreditAttribution: Risse commented
Status: Needs review » Reviewed & tested by the community
FileSize
1849754_chrome.png10.89 KB
1849754_firefox.png12.18 KB
1849754_ie9.png10.6 KB

Looks good in all browsers I tested in.

Windows 7 64bit

Internet Explorer 9
1849754_ie9.png

Firefox 19
1849754_firefox.png

Chrome 25
1849754_chrome.png

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.