API page: http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

      'nid' => array(
        'description' => 'The primary identifier for a node.',
        'type' => 'serial',
        'unsigned' => TRUE,
        'not null' => TRUE),
      'vid' => array(
        'description' => 'The current {node_revision}.vid version identifier.',
        'type' => 'int',
        'unsigned' => TRUE,
        'not null' => TRUE,
        'default' => 0),

The final item in each array should have a trailing comma, and the closing bracket should be on a line of its own, outdented.

Files: 
CommentFileSizeAuthor
#6 drupal-coding-style-hook-schema-1848516-6-do-not-test.patch1.81 KBIshaDakota
#1 drupal-coding-style-hook-schema-1848516-1.patch1.86 KBIshaDakota
FAILED: [[SimpleTest]]: [MySQL] 48,759 pass(es), 31 fail(s), and 0 exception(s).
[ View ]

Comments

IshaDakota’s picture

StatusFileSize
new1.86 KB
FAILED: [[SimpleTest]]: [MySQL] 48,759 pass(es), 31 fail(s), and 0 exception(s).
[ View ]

Patch with fix for coding style errors in D8.

IshaDakota’s picture

Status:Active» Needs review
marcingy’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, drupal-coding-style-hook-schema-1848516-1.patch, failed testing.

joachim’s picture

Status:Needs work» Reviewed & tested by the community

Looks good to me too.

Testbot is obviously on crack, as surely no tests look at api.php files.

IshaDakota’s picture

assuming this is OK, backport for D7 when ready.

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks! Committed the patch in #1 to 8.x and 7.x.

IshaDakota: Regarding #6, please read http://drupal.org/node/1319154#multiple-versions (making the 7.x patch was a waste of your time). :)

IshaDakota’s picture

@ jhodgdon Thanks for pointing that out - it's helpful to know. At least I only wasted my own time - I've certainly done much worse ;)

Automatically closed -- issue fixed for 2 weeks with no activity.