hp_slideshow broken when started on other page than frontpage [#1848272]

Comment #1

jsacksick CreditAttribution: jsacksick commented 27 November 2012 at 15:43

The js is only added on the frontpage, maybe it should be done differently by adding it on a preprocess view or writing a views plugin.

/**
 * Implements hook_preprocess_page().
 */
function commerce_kickstart_slideshow_preprocess_page(&$vars) {
  if ($vars['is_front']) {
    drupal_add_library('commerce_kickstart_slideshow', 'bxslider');
  }
}

As a quickfix, you can try to comment out the condition $vars['is_front'] and tell us if it solves anything.

Log in or register to post comments

Comment #2

rfamans CreditAttribution: rfamans commented 27 November 2012 at 18:22

Status:

Active

» Fixed

Yes, works great! We have a letterbox style slideshow for which there is sufficient space on each productlist page so that's why we did not want to restrict the slideshow to frontpage only.

Thanks for your help.

Log in or register to post comments

Comment #3

bojanz CreditAttribution: bojanz commented 27 November 2012 at 20:25

Category:	support	» bug
Status:	Fixed	» Active

We should fix this.

Log in or register to post comments

Comment #4

Summit CreditAttribution: Summit commented 3 December 2012 at 09:39

Hi,
Yes please. And please make the layout at the bottom of the slideshow (bxslider: <==> <==> <==>) theme independent.
Now when I try this on my own theme. Theses are not shown.

Thanks for this great slideshow by the way!
greetings, Martijn