Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When "Use AHAH to refresh the status update form without refreshing the page" is enabled and "Maximum status length" is set to 0 (zero) the ahah breaks with an error: "Notice: Undefined index: chars in statuses_save_js()"
If you suppress devel/error output the ahah will work but log the notice to the watchdog.
Comment | File | Size | Author |
---|---|---|---|
#4 | statuses-fixahah-1847704-4.patch | 1.24 KB | JvE |
#1 | statuses-fixahah-1847704-1.patch | 1.24 KB | JvE |
Comments
Comment #1
JvE CreditAttribution: JvE commentedAttached patch.
Comment #2
mathankumarc CreditAttribution: mathankumarc commentedLooks good to me.
Comment #3
IceCreamYou CreditAttribution: IceCreamYou commentedI agree with the direction of this patch, but the array listing the element names needs to be in the form order, not in alphabetical order, so that form elements without weights end up in the correct order in the response.
Thank you for the patch, JvE. Normally this is a trivial enough change that I would make it myself, but I'm in a rush at the moment. If you can make this minor change, we can go ahead and commit.
Comment #4
JvE CreditAttribution: JvE commentedThose elements all have a weight so the order won't matter.
For readability the form-order may be better though.
A proper wrapper in the form would be even better, but I am short on time as well :)
Comment #5
IceCreamYou CreditAttribution: IceCreamYou commentedOf course, but we may add other elements later, and it would be easy to forget. :-)
Committed to dev, thanks!