When "Use AHAH to refresh the status update form without refreshing the page" is enabled and "Maximum status length" is set to 0 (zero) the ahah breaks with an error: "Notice: Undefined index: chars in statuses_save_js()"
If you suppress devel/error output the ahah will work but log the notice to the watchdog.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JvE’s picture

Status: Active » Needs review
FileSize
1.24 KB

Attached patch.

mathankumarc’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

IceCreamYou’s picture

Status: Reviewed & tested by the community » Needs work

I agree with the direction of this patch, but the array listing the element names needs to be in the form order, not in alphabetical order, so that form elements without weights end up in the correct order in the response.

Thank you for the patch, JvE. Normally this is a trivial enough change that I would make it myself, but I'm in a rush at the moment. If you can make this minor change, we can go ahead and commit.

JvE’s picture

Those elements all have a weight so the order won't matter.
For readability the form-order may be better though.

A proper wrapper in the form would be even better, but I am short on time as well :)

IceCreamYou’s picture

Status: Needs work » Fixed

Those elements all have a weight so the order won't matter.

Of course, but we may add other elements later, and it would be easy to forget. :-)

Committed to dev, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.