Tweak the UI/UX and accessibility of the views bulk operations interface

Add tag

Get the usability guys involved too, we might want more than just the button value change...

Patch with renamed button label. No usability review considered.

@sun, are you saying we didn't or you hope we did (without looking)? There are fails, so I guess that's good then? :)

Sure we have tests which click the button.

Just in general i'm wondering whether it makes sense to allow to rename the button, so similar to the way you can do it on exposed forms.

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -83,8 +83,8 @@ public function views_form(&$form, &$form_state) {
-      // Replace the text with Update.
-    $form['actions']['submit']['#value'] = t('Update');
+      // Replace the text with Apply.
+    $form['actions']['submit']['#value'] = t('Apply');

It is working. Tested in Drupal8.x with latest code, some test nodes and a view.

For the label: "With selection"

"Actions bulk form" is the default label of the view plugin.

I have changed the default label from "Actions bulk form" to "Bulk Update". Removed description below the select element.

Here is the patch and inter-diff between this patch and the patch at #8

Oh sorry, I meant to say 'With selection' yeah. I like how it explicitly links the actions to the selected items. 'Bulk actions' only implies that. And, 'With selection' allows itself to be "autocompleted by the actual actions:

With selection: promote to front page
With selection: unpublish

Bulk actions: promote to front page
Bulk actions: unpublish

The latter just doesn't flow as much as the first. Subtle, but I think there's a difference in the amount of brain cycles needed to grasp what applies to what.

Not sure if we should leave out the label. It's worth investigating if we could do that in more places (or are already doing it)

To me, while "With Selection" may be more elegant, "Bulk Actions" seems more straightforward (as a label, at least).

Another semantic point: The 'help' text in the action_views_data() is in the second person (you):

Add a form element that lets you apply actions to multiple items

Outside of one other ( Content: Author uid), it is the only field help text that is in the second person. Also, you don't need to apply actions to "multiple items" - you could apply to just one. Might it be better as:

Add a form element that applies actions to one or more items

Not sure if there is a prevailing norm, as there isn't really guidance on second or third person in the Interface Text Stye Guide

Small change from #13. Since patch 13 failed in test, the inter-diff file is between #7 and this patch.

This patch include addition change for @sun's comment at #15

BTW, I'm not sure whether we actually need any kind of label for the select box.

We might want to change it to "With selection", but additionally set #title_display to 'invisible'.

Adding a tag :)

Screenshot after apply patch #20

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -75,16 +75,16 @@ public function views_form(&$form, &$form_state) {
+      '#title' => t('With selection'),
+      '#title_display' => 'invisible',

It's invisible so i think we should describe for that this is actually used.

#20: drupal-1845840-20.patch queued for re-testing.

@dawehner, what is a better way to describe it? Or just leave it empty.

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -75,7 +75,8 @@ public function views_form(&$form, &$form_state) {
+      '#title' => '',

What about 'Bulk Update'?

Thanks for working on that!

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -51,21 +51,25 @@ public function views_form(&$form, &$form_state) {
+        // We are not able to determine a main "title" for each row, so we can
+        // only output a generic label.

We could introduce a configuration option on the field, but i'm not sure this is worth to do and wouldn't confuse the site builder a lot (because most will never see it).

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -73,22 +77,29 @@ public function views_form(&$form, &$form_state) {
+      '#title' => t('With selection'),
+      '#title_display' => 'invisible',

Still not sure whether this is actually helpful for people.

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -104,6 +115,8 @@ public function views_form_submit(&$form, &$form_state) {
+        // @todo This must not be based on row index, unless the entire view
+        //   results as well as the form are cached and not re-executed on POST.

You could maybe explain it, who you most not be based on row index. I guess you would need some kind of hash as value on the row, and determine that on the $result as well?

+++ b/core/modules/action/lib/Drupal/action/Plugin/views/field/BulkForm.phpundefined
@@ -113,7 +126,10 @@ public function views_form_submit(&$form, &$form_state) {
+          '@count' => $count,

No need for @count in format_plural

2) Definitely helpful for screen-readers to make sense of the select options. Also allows people to unset/undo the #title_display property and actually show the label in their themes.

Sure absolutly, i'm wondering about the actual string. What about "With action" or something more direct.

Regarding the usage of row index: it's no problem to fix this in another issue.

Kinda surprising to see a move towards no visible label at all. What makes this so obvious to everybody that we don't need to show one? I still think 'With selection' is the best option :) Not because of elegance but because it helps people connect the dots, linking the operations to the checkboxes.

Adding a tag, i don't think "with selection" is an accessible label.

be gone

This indeed is a huge improvement.

Committed/pushed to 8.x, thanks!

@dawehner I'm trying to understand your concern with '#title' => t('With selection'), - is it just that it isn't clear in context?

#42
It doesn't seem to be obvious for me that "with selection" gives you enough context to understand that this is an action you want to select.