Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Coming from http://drupal.org/node/1839078#comment-6743488:
- TypedData classes refer to interfaces without using their namespace. That's only valid if the namespace is imported, but partly that's not the case.
- TypedData array keys use names with spaces, e.g. 'list class'. Since we are using annotations we've migrated to go with underscores everywhere now. Finally consistentcy, so let's follow that.
- To avoid issues with late static binding, we should avoid using self::. But current field item implementations do so - replace that
selfusages withstatic.
Let's save us some pain and postpone this until bigger patches like #1778178: Convert comments to the new Entity Field API made it in.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | typeddata-doc-1844112-6.patch | 7.41 KB | Arla |
| #3 | typeddata-doc-1844112-3.patch | 7.76 KB | Arla |
Comments
Comment #1
fagoComment #2
mgiffordComment #3
ArlaFound (and fixed) some bad doc-comments with
Comment #4
mgiffordGreat. Thanks @Arla
Comment #6
ArlaReroll
Comment #11
borisson_We don't really do these kinds code/documentation style updates per module.